Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long-term solution for semantically correct headers #1486

Closed
akegan opened this issue Jul 7, 2021 · 0 comments
Closed

Long-term solution for semantically correct headers #1486

akegan opened this issue Jul 7, 2021 · 0 comments
Labels
a11y An accessibility bug

Comments

@akegan
Copy link
Contributor

akegan commented Jul 7, 2021

As a part of addressing #142 in #1450, there were issues with the InfoCard having header levels that jumped by more than one level from the outside to the inside of the card. As you can see from this comment we just updated the info card to an h3 to fix the errors for now, but the longer term fix is to make the header level configurable as a prop on the component so that the level can be semantically correct in any other context

More info about this a11y rule

Acceptance Criteria

  1. Add a prop to InfoCard to set the title header level, default to a reasonable level
  2. Look for other components where the header level might need to be configurable as a prop for them to fit correctly into the context of a page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y An accessibility bug
Projects
None yet
Development

No branches or pull requests

2 participants