Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate SMC CSS overrides into Core #305

Closed
bk3c opened this issue May 20, 2020 · 6 comments
Closed

Consolidate SMC CSS overrides into Core #305

bk3c opened this issue May 20, 2020 · 6 comments
Assignees

Comments

@bk3c
Copy link
Contributor

bk3c commented May 20, 2020

When doing SMC QA over at housingbayarea, we noticed that the styles in /pages/AdditionalResources.scss were being applied globally, rather than just to the intended page. While there's probably a future path for having that kind of component-specific styling (with the proper .module.scss as @software-project pointed out), it sounds like it will be better in the short term to just roll the style variants back up into the core CSS and adjust the class usage on the relevant page appropriately.

@slowbot
Copy link
Collaborator

slowbot commented May 22, 2020

@bk3c The first pass of this is done to fix the global css overrides.
housingbayarea#57

Remaning to do include:

  • Replace info-card reference with info-card component from bloom core
  • Move shadow-left style to bloom core
  • Demo component for "info-card-grid" with a header element and card grid in partners reference then move to bloom core
  • Resolve other jurisdiction Resources pages

@slowbot
Copy link
Collaborator

slowbot commented May 22, 2020

@software-project Do you think you have time to take these to dos on early next week? Happy to jump on a call and talk through it.

@software-project
Copy link
Contributor

@slowbot will do

@slowbot
Copy link
Collaborator

slowbot commented May 26, 2020

@software-project I created a prototype of info-card-grid markup and styles here: #307

You can use this as the starting point for the new component

@bk3c
Copy link
Contributor Author

bk3c commented Jun 17, 2020

I think this is done. @slowbot can you confirm?

@bk3c bk3c added this to the Sprint Ending June 26 milestone Jun 17, 2020
@bk3c
Copy link
Contributor Author

bk3c commented Jun 29, 2020

Done per @software-project!

@bk3c bk3c closed this as completed Jun 29, 2020
YazeedLoonat pushed a commit to YazeedLoonat/bloom that referenced this issue May 31, 2022
Small fixes to get the cypress tests running and add them to our Travis presumit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants