-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate SMC CSS overrides into Core #305
Comments
@bk3c The first pass of this is done to fix the global css overrides. Remaning to do include:
|
@software-project Do you think you have time to take these to dos on early next week? Happy to jump on a call and talk through it. |
@slowbot will do |
@software-project I created a prototype of info-card-grid markup and styles here: #307 You can use this as the starting point for the new component |
I think this is done. @slowbot can you confirm? |
Done per @software-project! |
Small fixes to get the cypress tests running and add them to our Travis presumit.
When doing SMC QA over at housingbayarea, we noticed that the styles in
/pages/AdditionalResources.scss
were being applied globally, rather than just to the intended page. While there's probably a future path for having that kind of component-specific styling (with the proper .module.scss as @software-project pointed out), it sounds like it will be better in the short term to just roll the style variants back up into the core CSS and adjust the class usage on the relevant page appropriately.The text was updated successfully, but these errors were encountered: