Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lottery results section #1034

Merged
merged 9 commits into from
Mar 8, 2021
Merged

Add lottery results section #1034

merged 9 commits into from
Mar 8, 2021

Conversation

software-project
Copy link
Contributor

Resolves #987

Note: I'm wondering if this is a good time to extract event components... either to just theirs own file or to ui-components @slowbot @jaredcwhite @dominikx96 what do you think?

@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-j5cpxi February 22, 2021 22:55 Inactive
@netlify
Copy link

netlify bot commented Feb 22, 2021

Deploy preview for clever-edison-cd22c1 ready!

Built with commit d50d7da

https://deploy-preview-1034--clever-edison-cd22c1.netlify.app

@slowbot
Copy link
Collaborator

slowbot commented Feb 25, 2021

@software-project I do think there are repeatable styles across all event displays so I think it would be a good idea. I defer to others about file separation

@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-s1kaur February 26, 2021 09:10 Inactive
@software-project
Copy link
Contributor Author

@jaredcwhite I went ahead and extracted those components to ui-components. Could you have a look if it's fine?

@jaredcwhite
Copy link
Collaborator

Great idea! I think I'll redo my work in #1045 to go off of this instead.

@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-hsvlmd February 27, 2021 08:02 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-zpncp0 March 1, 2021 16:46 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-rsj4r8 March 1, 2021 17:28 Inactive
@slowbot
Copy link
Collaborator

slowbot commented Mar 1, 2021

@software-project @jaredcwhite Reviewed and made some small updates.

Only think I would recommend would think about the placement of EventDate. Not sure of this is a "section" or just a "text" style. I usually would reserve "section" for larger layout based components, but that might just be my preference.

@software-project
Copy link
Contributor Author

@slowbot do you think like listing_sidebar/events would be a better place for it?

@slowbot
Copy link
Collaborator

slowbot commented Mar 4, 2021

@software-project That sounds fine to me.

@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-tjizpj March 8, 2021 13:06 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-kqbsb3 March 8, 2021 13:07 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-add-lotter-fpidv5 March 8, 2021 13:40 Inactive
@software-project software-project merged commit e58a7d7 into master Mar 8, 2021
YazeedLoonat pushed a commit to YazeedLoonat/bloom that referenced this pull request May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing: Lottery Results on Listing
4 participants