-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lottery results section #1034
Conversation
Deploy preview for clever-edison-cd22c1 ready! Built with commit d50d7da https://deploy-preview-1034--clever-edison-cd22c1.netlify.app |
@software-project I do think there are repeatable styles across all event displays so I think it would be a good idea. I defer to others about file separation |
0a609c4
to
8ef3c31
Compare
@jaredcwhite I went ahead and extracted those components to ui-components. Could you have a look if it's fine? |
Great idea! I think I'll redo my work in #1045 to go off of this instead. |
@software-project @jaredcwhite Reviewed and made some small updates. Only think I would recommend would think about the placement of EventDate. Not sure of this is a "section" or just a "text" style. I usually would reserve "section" for larger layout based components, but that might just be my preference. |
@slowbot do you think like |
@software-project That sounds fine to me. |
…into add-lottery-results
…loom-housing#1034) Co-authored-by: Michal Plebanski <michalp@airnauts.com>
Resolves #987
Note: I'm wondering if this is a good time to extract event components... either to just theirs own file or to ui-components @slowbot @jaredcwhite @dominikx96 what do you think?