Added filters to the ada and preferences #1039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dominikx96 Annual Sorted High - low Monthly sorted Low to high |
slowbot
reviewed
Feb 25, 2021
There was a problem hiding this comment.
@dominikx96 Filters work as expected, but income sorting still has gaps based on monthly to annual
|
@slowbot thanks! I'll try to reproduce it. |
|
@slowbot income sorting should work as expected, it's ready for review. |
|
Deploy preview for clever-edison-cd22c1 ready! Built with commit de0da2a https://deploy-preview-1039--clever-edison-cd22c1.netlify.app |
|
@dominikx96 I think ascending is still not working as expected. I expect for ascending, lowest value would be at the top and the n/a or blanks would be below any rows that had a value in them.
|
slowbot
requested changes
Mar 1, 2021
|
@slowbot I moved empty values to the bottom of the table - implemented for each column. |
YazeedLoonat
pushed a commit
to YazeedLoonat/bloom
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1020
@slowbot I implemented filtering (and disabled sorting) for Request ADA and Preference Claimed.
I don't see any issues for income sorting (I can sort ascending, descending) -could you provide more details (and/or screenshots)?