Feature/master order application list #1063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 5, 2021 23:04
…; Add all missing joins to application list query
…master_order-application-list
Add fix for linter issues
|
Deploy preview for clever-edison-cd22c1 ready! Built with commit 1868f93 https://deploy-preview-1063--clever-edison-cd22c1.netlify.app |
pbn4
reviewed
Mar 10, 2021
| @IsOptional({ groups: [ValidationsGroupsEnum.default] }) | ||
| @IsString({ groups: [ValidationsGroupsEnum.default] }) | ||
| @IsIn(Object.keys(OrderParamEnum), { groups: [ValidationsGroupsEnum.default] }) | ||
| @Transform((value: string | undefined) => (value ? value : OrderParamEnum.DESC), { |
There was a problem hiding this comment.
Is toClassOnly required here since this is only ever used for input?
| import { PaginationQueryParams } from "../shared/dto/pagination.dto" | ||
| import { ValidationsGroupsEnum } from "../shared/validations-groups.enum" | ||
| import { defaultValidationPipeOptions } from "../shared/default-validation-pipe-options" | ||
| import { applicationPreferenceExtraModels } from "./entities/application-preferences.entity" | ||
| import { ApplicationCsvExporter } from "../csv/application-csv-exporter" | ||
|
|
||
| enum OrderByParamEnum { |
There was a problem hiding this comment.
So far we have not been adding Enum suffix to the enums
Removed toClassOnly from Transform decorator options Removed Enum suffix from OrderByParamEnum and OrderParamEnum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #866