Autofill applications for signed in users #1111

jaredcwhite · 2021-04-08T16:54:01Z

Resolves #1040 #1041

There's also an old duplicate here: #249

This also encompasses some fixes to the application form flow I noticed when signed in.

netlify · 2021-04-08T16:58:59Z

Deploy preview for clever-edison-cd22c1 ready!

Built with commit e7e4802

https://deploy-preview-1111--clever-edison-cd22c1.netlify.app

jaredcwhite · 2021-04-08T22:33:27Z

@kathyccheng Here's the rundown of all the stuff that will get changed or deleted when the application is loaded up:

deleted: ids, timestamps, etc.
language: "en" (I could be wrong but it looks like all applications are being submitted as English? I don't see anywhere we're actually capturing this data)
acceptedTerms: false
status: "submitted"

And then various other sections being deleted/reset:

preferences
applicant.workInRegion
applicant.workAddress

Let me know if that makes sense to you

jaredcwhite · 2021-04-08T22:38:49Z

@slowbot Here's that issue I mentioned regarding the final page link:

Also, on the first form step when somebody's already logged in, I wasn't sure what to do there so there's just a bit of white space. Let me know if you have any thoughts.

kathyccheng · 2021-04-09T22:33:39Z

@jaredcwhite all the things you removed makes sense to me!

kathyccheng · 2021-04-09T22:34:36Z

@slowbot will let you take a look at whitespace. for the weird No thanks, I'm Done thing, were you able to figure it out @jaredcwhite?

jaredcwhite · 2021-04-12T20:51:33Z

I still need guidance on the "No thanks" language.

kathyccheng · 2021-04-12T20:56:40Z

Can we do "I'm done" or just remove it? @jaredcwhite @slowbot

jaredcwhite · 2021-04-12T21:08:28Z

I'm happy to change it to "I'm done" but I don't know how to change the translations.

kathyccheng · 2021-04-12T21:13:00Z

Like we don't have the translations, or you can't find it in our translation file? @jaredcwhite

jaredcwhite · 2021-04-12T21:14:04Z

Oh, I mean I don't know what the new translations should be.

kathyccheng · 2021-04-12T21:20:34Z

Gotcha! That's no problem, I'll add it to the next wave of translations with our contractors!

jaredcwhite · 2021-04-12T21:24:31Z

Sounds good. And I just realized I have some strings which need translating on the new autofill page(s), so let me move those to the English JSON which I'll send to you for reference.

jaredcwhite · 2021-04-12T22:42:18Z

@kathyccheng Here's what I've got so far:

{
  "application": {
    "autofill": {
      "saveTime": "Save time by using the details from your last application",
      "prefillYourApplication": "We'll simply pre-fill your application with the following details, and you can make updates as you go.",
      "start": "Start with these details",
      "reset": "Reset and start fresh"
    },
    "household": {
      "addMembers": {
        "doubleCheck": "Please double-check the information for each household member.",
      },
    },
    "review": {
      "confirmation": {
        "imdone": "I'm done."
      }
    }
  }
}

kathyccheng · 2021-04-13T01:16:52Z

Perfect, thanks!

emilyjablonski · 2021-04-14T15:40:18Z

sites/public/pages/applications/contact/name.tsx

@@ -45,6 +50,20 @@ export default () => {
  const emailPresent: string = watch("applicant.emailAddress")
  const noEmail: boolean = watch("applicant.noEmail")
  const clientLoaded = OnClientSide()
+  if (!autofilled && clientLoaded && application.autofilled) setAutofilled(true)
+
+  const AutofillIcon = () => {


(Non-blocking) I find this name to be a lil confusing, maybe something like DisabledIcon or LockIcon?

That makes sense.

emilyjablonski · 2021-04-14T15:42:00Z

sites/public/pages/applications/review/confirmation.tsx

-              {t("account.createAccount")}
-            </Button>
-          </div>
+          {initialStateLoaded && !profile && (


Just curious what this change is for?

It should only show an option to create a new account if the logged-in state has loaded and the user isn't logged in.

emilyjablonski · 2021-04-14T15:44:35Z

sites/public/src/forms/applications/FormSummaryDetails.tsx

-            </>
-          )}
-        </div>
+        {!hidePreferences && (


Curious about the need behind this change?

We shouldn't show any preference information on the autofill preview since we're blanking them all out.

emilyjablonski · 2021-04-14T15:45:01Z

ui-components/__tests__/forms/DOBField.test.tsx

@@ -28,4 +29,9 @@ describe("<DOBField>", () => {
    expect(getByLabelText("Day")).not.toBeNull()
    expect(getByLabelText("Year")).not.toBeNull()
  })
+
+  it("can toggle all internal fields to be disabled", () => {


emilyjablonski · 2021-04-14T15:52:27Z

ui-components/src/forms/HouseholdMemberForm.tsx

  const { member, type } = props
  const router = useRouter()
+  let editMode = props.editMode


Can we just use a default prop value here?

Man, this must have been some weird debugging thing. Bad pattern! 😬 Will fix…

jaredcwhite · 2021-04-15T21:32:47Z

OK I figured out the infinite render issue and got that fixed…but I'm not super happy with the code. 50 LoC just to check an endpoint for data and either redirect or provide a form handler feels excessive. Open to any feedback on how to improve.

emilyjablonski · 2021-04-16T19:29:19Z

ui-components/src/forms/HouseholdMemberForm.tsx

  const { member, type } = props
  const router = useRouter()
+  const editMode = props.editMode !== false // undefined should default to true


Was hoping to use a default prop of false here but this is def non-blocking!

I think the weirdness is that the default state should actually be true, so only if editMode prop is present and set specifically to false should it be set false.

dominikx96

@jaredcwhite probably it's not in this scope, but when I filled out an application, I saw no primary applicant data:

Same situation with "Do you work in question.

dominikx96 · 2021-04-19T15:15:57Z

sites/public/lib/appAutofill.ts

+  }
+
+  addDefaults() {
+    ;["id", "createdAt", "updatedAt", "deletedAt", "listing", "submissionDate"].forEach((key) => {


; <- I suppose it's not necessary :D

Prettier is adding it…must have thought there could be a JS error otherwise.

dominikx96 · 2021-04-19T15:20:03Z

sites/public/lib/appAutofill.ts

+    unsetIdentifiers(this.application.applicant)
+    unsetIdentifiers(this.application.mailingAddress)
+
+    if (this.application.alternateAddress) unsetIdentifiers(this.application.alternateAddress)


Are sure that it works? I think alternateAddress is loaded from the blackApplication.ts and it's an object, so it always has values (?) NOT SURE - just to check :)

The similar situation below with alternateContact

Everything's coming directly from the backend in an autofill scenario (which is only when this code gets run), so I'm trying to strip out or change data to fit that flow.

dominikx96 · 2021-04-19T15:21:06Z

sites/public/lib/appAutofill.ts

+      street: "",
+      street2: "",
+      city: "",
+      state: "",
+      zipCode: "",
+      county: "",
+      latitude: null,
+      longitude: null,


I think could be better to load defaults from the blankApplication.ts.

Good point, I could load that in and copy the object over.

dominikx96 · 2021-04-19T15:27:13Z

sites/public/pages/applications/start/autofill.tsx

+              <Button
+                styleType={AppearanceStyleType.primary}
+                onClick={() => {
+                  useDetails = true


Shouldn't be processed by React and useState? I mean useDetails variable.

Well it's not a state change, it's just a runtime flag that lets the submit handler know which action to take. I specifically wouldn't want to trigger any re-render.

jaredcwhite · 2021-04-19T19:45:30Z

@dominikx96 Jesse saw the same issue as well so I will investigate further. Thanks for the feedback!

jaredcwhite · 2021-04-19T22:07:48Z

@slowbot I think I identified and fixed a low-level bug regarding object references that was causing some data loss…the bug had been present before the autofill PR, but never triggered because we'd never needed to perform a wholesale swap of application data mid-flow before. Can you do one more QA pass?

jaredcwhite · 2021-04-20T19:01:02Z

Looking good testing on Netlify preview, got the thumbs up from @slowbot…so plan to merge after fixing the conflict.

jaredcwhite · 2021-04-20T21:09:10Z

Getting some Cypress timeouts but I'm assuming those are spurious. 😬 LGTM

jaredcwhite added 4 commits April 7, 2021 12:22

Stub out code needed for applications autofill

26f7a23

Set up Autofill page, add SWR to the public app

f8b9f4b

Additional work to implement the Autofill flow

5dcf9ab

Address issues throughout the forms flow

3617bc6

jaredcwhite added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Apr 8, 2021

exygy-dev temporarily deployed to bloom-refere-autofill-a-dhffff April 8, 2021 16:54 Inactive

remove stray consoles

45ddea7

exygy-dev temporarily deployed to bloom-refere-autofill-a-lmen8z April 12, 2021 21:12 Inactive

Add tests and move language strings to locales

5215194

exygy-dev temporarily deployed to bloom-refere-autofill-a-sl0grv April 12, 2021 23:03 Inactive

jaredcwhite added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Apr 13, 2021

jaredcwhite requested review from dominikx96, emilyjablonski and slowbot April 13, 2021 02:26

Public site redirect correctly after sign in

d98d84c

exygy-dev temporarily deployed to bloom-refere-autofill-a-lzfl6v April 13, 2021 20:48 Inactive

jaredcwhite mentioned this pull request Apr 13, 2021

Sign In from application form flow doesn't redirect back to the application forms #1102

Closed

emilyjablonski reviewed Apr 14, 2021

View reviewed changes

jaredcwhite added 2 commits April 14, 2021 20:35

Changes from PR feedback

31adbee

Merge branch 'master' into autofill-applications

e633c82

jaredcwhite changed the title ~~Autofill applications for signed in users~~ DO NOT MERGE – Autofill applications for signed in users Apr 15, 2021

Avoid infinite rerenders

93a9e50

exygy-dev temporarily deployed to bloom-refere-autofill-a-cygjar April 15, 2021 21:08 Inactive

jaredcwhite changed the title ~~DO NOT MERGE – Autofill applications for signed in users~~ Autofill applications for signed in users Apr 15, 2021

emilyjablonski reviewed Apr 16, 2021

View reviewed changes

emilyjablonski approved these changes Apr 16, 2021

View reviewed changes

dominikx96 requested changes Apr 19, 2021

View reviewed changes

Ensure form steps never use an orphaned application reference

756a30a

exygy-dev temporarily deployed to bloom-refere-autofill-a-x7ingd April 19, 2021 21:56 Inactive

Blank out work address using blankApplication

1f99d7f

exygy-dev temporarily deployed to bloom-refere-autofill-a-4kaflc April 20, 2021 18:12 Inactive

jaredcwhite added 2 commits April 20, 2021 13:25

Fixing styling and a data bug on Choose Language

1d77c5b

Merge branch 'master' into autofill-applications

e7e4802

exygy-dev temporarily deployed to bloom-refere-autofill-a-nqukme April 20, 2021 20:30 Inactive

jaredcwhite merged commit e6ac21c into master Apr 20, 2021

jaredcwhite mentioned this pull request Apr 20, 2021

Use correct listingId when redirecting from Sign In #1147

Merged

Autofill applications for signed in users #1111

Autofill applications for signed in users #1111

Conversation

jaredcwhite commented Apr 8, 2021 • edited Loading

netlify bot commented Apr 8, 2021 • edited Loading

jaredcwhite commented Apr 8, 2021

jaredcwhite commented Apr 8, 2021

kathyccheng commented Apr 9, 2021

kathyccheng commented Apr 9, 2021

jaredcwhite commented Apr 12, 2021

kathyccheng commented Apr 12, 2021

jaredcwhite commented Apr 12, 2021

kathyccheng commented Apr 12, 2021

jaredcwhite commented Apr 12, 2021

kathyccheng commented Apr 12, 2021

jaredcwhite commented Apr 12, 2021 • edited Loading

jaredcwhite commented Apr 12, 2021 • edited Loading

kathyccheng commented Apr 13, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredcwhite commented Apr 15, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominikx96 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dominikx96 Apr 19, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaredcwhite commented Apr 19, 2021

jaredcwhite commented Apr 19, 2021

jaredcwhite commented Apr 20, 2021

jaredcwhite commented Apr 20, 2021

jaredcwhite commented Apr 8, 2021 •

edited

Loading

netlify bot commented Apr 8, 2021 •

edited

Loading

jaredcwhite commented Apr 12, 2021 •

edited

Loading

jaredcwhite commented Apr 12, 2021 •

edited

Loading

dominikx96 Apr 19, 2021 •

edited

Loading