Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/flaky cypress tests #1115

Merged
merged 41 commits into from
Apr 27, 2021
Merged

test/flaky cypress tests #1115

merged 41 commits into from
Apr 27, 2021

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Apr 9, 2021 •
edited
Loading

  • Changes the Cypress job to run in production mode instead of dev mode (cuts the time in half from 20 min to 10 min and removes the flakiness)
  • Stores videos and screenshots for tests that fail in CircleCI, which has been critical for debugging the failing tests
  • Removes tests that depended on the name of a listing, as the ordering isn't stable and the seed data could change (fixes the broken navigation issues)
  • Comments out the terms suite tests that are broken on master - there is an incoming fix in Add env variables to control rate limits #1155

@emilyjablonski emilyjablonski added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Apr 9, 2021
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-ef3vu9 April 9, 2021 19:11 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-fzcucd April 9, 2021 19:24 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-ck4otn April 9, 2021 19:29 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-flor87 April 9, 2021 19:31 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-foochz April 9, 2021 19:40 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-fcfadq April 9, 2021 19:52 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-szie7n April 15, 2021 23:32 Inactive
@netlify
Copy link

netlify bot commented Apr 15, 2021 •
edited
Loading

Deploy preview for clever-edison-cd22c1 ready!

Built with commit f518bd0

https://deploy-preview-1115--clever-edison-cd22c1.netlify.app

@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-31um2r April 15, 2021 23:47 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-x12dhb April 15, 2021 23:47 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-lwmto8 April 15, 2021 23:59 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-vmcsny April 16, 2021 00:07 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-osigut April 16, 2021 00:14 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-of7u56 April 16, 2021 00:40 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-yempvc April 16, 2021 00:42 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-pp8zk0 April 16, 2021 00:52 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-ehonw6 April 16, 2021 01:24 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-i9jy1i April 16, 2021 19:40 Inactive
@emilyjablonski emilyjablonski changed the title testing flaky cypress fixes test/flaky cypress tests Apr 16, 2021
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-qy9wqu April 16, 2021 19:58 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-1lkz6v April 16, 2021 20:09 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-q5vk3z April 16, 2021 20:27 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-jcgchm April 16, 2021 20:41 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-udynjw April 16, 2021 21:15 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-ql0di9 April 16, 2021 22:02 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-gdjgko April 19, 2021 19:44 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-0irjzf April 19, 2021 21:00 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-sgs9me April 20, 2021 19:14 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-test-flaky-x7mzm6 April 23, 2021 19:12 Inactive
@emilyjablonski emilyjablonski added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Apr 23, 2021
jaredcwhite
jaredcwhite approved these changes Apr 26, 2021
View reviewed changes
Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized I hadn't formally added my review here. LGTM! 👍

dominikx96
dominikx96 approved these changes Apr 27, 2021
View reviewed changes
Copy link
Collaborator

@dominikx96 dominikx96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emilyjablonski thanks for your effort, LGTM! 🚀

@emilyjablonski emilyjablonski merged commit c1aeb2c into master Apr 27, 2021
@emilyjablonski emilyjablonski deleted the test/flaky-cypress-tests branch April 27, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcwhite jaredcwhite jaredcwhite approved these changes

@dominikx96 dominikx96 dominikx96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emilyjablonski @jaredcwhite @dominikx96 @exygy-dev