Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/new referral component #1146

Merged
merged 3 commits into from
Apr 22, 2021
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Apr 20, 2021

See this issue for more information: #1142

For some reason I couldn't get the phone icon to render within the story, but it renders just fine within the application as seen in the screenshot below:
Screen Shot 2021-04-20 at 2 02 02 PM

@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ne-4vqnqc April 20, 2021 20:07 Inactive
@emilyjablonski emilyjablonski linked an issue Apr 20, 2021 that may be closed by this pull request
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ne-bhpmrl April 20, 2021 20:12 Inactive
@slowbot
Copy link
Collaborator

slowbot commented Apr 20, 2021

@emilyjablonski I think icons are still broken in storybook @jaredcwhite Is that right?

@emilyjablonski
Copy link
Collaborator Author

@jaredcwhite Hoping to get your review

Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment due to recent master styling update, otherwise LGTM!

const linkedPhoneNumber = `tel:${props.phoneNumber.replace(/[-()]/g, "")}`

return (
<section className="aside-block -mx-4 pt-0 md:mx-0 md:pt-4">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove all the utility classes now and just use aside-block (due to merge of #1140)

@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ne-qbro5v April 22, 2021 20:53 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-feature-ne-8lx9b6 April 22, 2021 20:54 Inactive
@emilyjablonski
Copy link
Collaborator Author

@jaredcwhite Okidoke, made the requested change :)

@jaredcwhite
Copy link
Collaborator

LGTM!

@emilyjablonski emilyjablonski merged commit b8e98b7 into master Apr 22, 2021
@emilyjablonski emilyjablonski deleted the feature/new-referral-component branch April 22, 2021 22:39
YazeedLoonat pushed a commit to YazeedLoonat/bloom that referenced this pull request May 31, 2022
…housing#1146)

* feat: show tags on listing cards for community programs, a11y

* fix: build fix

* refactor: pr feedback

* feat: adds sorting to programs in listing tags

Co-authored-by: Sean Albert <smabert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom component for referral CTA
4 participants