Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): 404 issues in my application and settings #1164

Merged
merged 2 commits into from
Apr 23, 2021
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Apr 22, 2021

Fixes #1151 and #1152

  • Account Settings from the dashboard would 404
  • Clicking on a link to an individual application from My Applications would 404

Use the Netlify preview to test!

@emilyjablonski emilyjablonski added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Apr 22, 2021
@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-404s-du2qv3t8 April 22, 2021 23:01 Inactive
@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-404s-umtmf5bv April 22, 2021 23:12 Inactive
@netlify
Copy link

netlify bot commented Apr 22, 2021

Deploy preview for clever-edison-cd22c1 ready!

Built with commit 3c9f3cc

https://deploy-preview-1164--clever-edison-cd22c1.netlify.app

@emilyjablonski
Copy link
Collaborator Author

They're all working on the deploy preview! :)

@emilyjablonski emilyjablonski linked an issue Apr 22, 2021 that may be closed by this pull request
@emilyjablonski emilyjablonski added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Apr 22, 2021
Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! One question: you deleted the file sites/public/pages/account/settings.tsx, was that intentional?

@emilyjablonski
Copy link
Collaborator Author

Yep it wasn't in use anywhere ¯_(ツ)_/¯ @jaredcwhite

@emilyjablonski
Copy link
Collaborator Author

Checked in w Jared offline, said it looks good to go!

@emilyjablonski emilyjablonski merged commit c29d46f into master Apr 23, 2021
@emilyjablonski emilyjablonski deleted the fix/404s branch April 23, 2021 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My Applications link broken Account Settings Bug
3 participants