Feature/dynamic preferences #1167

dominikx96 · 2021-04-23T14:13:15Z

Closes: #1130

accesslint

There are accessibility issues in these changes.

ui-components/src/helpers/preferences.tsx

+
+          return (
+            <>
+              <Select


kathyccheng · 2021-04-23T14:33:12Z

@dominikx96 how about /preferences/all?

accesslint

👏 You fixed the issue(s)! Great work.

accesslint

👏 You fixed the issue(s)! Great work.

accesslint

👏 You fixed the issue(s)! Great work.

netlify · 2021-04-28T07:15:29Z

Deploy preview for clever-edison-cd22c1 ready!

Built with commit 5dc694c

https://deploy-preview-1167--clever-edison-cd22c1.netlify.app

dominikx96 · 2021-04-28T07:18:13Z

The Netlify errors are showing this btw:

Error: Export encountered errors on following paths:
5:27:14 AM: 	/applications/preferences/displaced
5:27:14 AM: 	/es/applications/preferences/displaced
5:27:14 AM: 	/vi/applications/preferences/displaced
5:27:14 AM: 	/zh/applications/preferences/displaced
5:27:14 AM:     at exportApp (/opt/build/repo/node_modules/next/dist/export/index.js:25:1103)
5:27:14 AM:     at processTicksAndRejections (internal/process/task_queues.js:97:5)
5:27:14 AM: error Command failed with exit code 1.

Thanks! I forgot to delete the old preference page from the next config, now netlify deploy is working!

accesslint

👏 You fixed the issue(s)! Great work.

accesslint

👏 You fixed the issue(s)! Great work.

accesslint

👏 You fixed the issue(s)! Great work.

dominikx96 · 2021-04-28T09:37:56Z

I also fixed tests to fetch listing with at least 2 preferences to test every step without fail :)

jaredcwhite

Nice work! Lots of moving parts here. I just had a few comments, mostly around making things easier to scan/maintain.

jaredcwhite · 2021-04-28T21:46:14Z

sites/public/pages/applications/preferences/all.tsx

+    conductor.routeToNextOrReturnUrl()
+  }
+
+  const buildOptionName = useCallback((metaKey: string, option: string) => {


Can we take this out of a React callback and move it up somewhere as just a regular function? From what I can tell it doesn't require anything React-specific.

Sure thing! I noticed, I can move it to the preference helper and share between public and partners forms :)

jaredcwhite · 2021-04-28T21:47:37Z

sites/public/pages/applications/preferences/all.tsx

+
+  const watchPreferences = watch(allOptionFieldNames)
+
+  function uncheckPreference(metaKey: string, options: FormMetadataOptions[]) {


use the const fnNane = arrow syntax for consistency?

jaredcwhite · 2021-04-28T21:50:27Z

sites/public/pages/applications/preferences/all.tsx

+  const hhMmembersOptions = useMemo(() => {
+    const { applicant } = application
+
+    const primaryApplicant = (() => {


I'm finding it hard to follow here why an IIFE inside of a useMemo is required? Can we simplify the pattern?

I used IIFE because we have conditions and some logic inside, so it prevents the use of let and I think it's more readable and it creates scope for primaryApplicant.

jaredcwhite · 2021-04-28T21:52:05Z

sites/public/pages/applications/preferences/all.tsx

+  /*
+    Rehydration fix
+  */
+  const [hasMounted, setHasMounted] = useState(false)


Take a look at the OnClientSide hook—it's a way of doing this we've used before because of the weird form hydration issues

jaredcwhite · 2021-04-28T22:04:51Z

ui-components/src/actions/ExpandableContent.tsx

+  children: React.ReactChild
+}
+
+const ExpandableContent = ({ children }: ExpandableContentProps) => {


I realize this is sort of based on code I'd added in the previous preferences pages…but looking at this fresh I'm wondering if we can refactor to use a simple details/summary markup in the HTML directly. Prior art in the WhatToExpect component. Thoughts?

Hmm, we can - but here we have two different labels: read less / read more.
We can create a listener to watch this state and show the proper label, but I'm not sure which one is simpler in this case :D

Also - this solution is open e.g for animation in the future 💅

Good point. Maybe we can take a second look at this later on and see if it's something to standardize on for all the read more/less instances around the codebase.

accesslint

👏 You fixed the issue(s)! Great work.

dominikx96 and others added 22 commits April 20, 2021 15:07

Created expandable content component

14b5634

Exported ExpandableContext component

d631e25

Updated seeds to add preference links

4d2e866

Added new preferences page - keep old for now

ef61f11

Moved reusable logic to the helper

3c2811c

Built dynamic form

c016bb9

Add hhMemberSelect type to InputTypes (#1144)

596d7dc

Added household member type

8591a07

Integrated hh select

f618408

Refactored all FormAddress instances

408e263

Created helper to have an access to nested properties from string

dcd0bb9

Exported helper

8116d62

Validate nested form options

7e786af

Added validation function

55cf25a

Added form validation

863d282

Added new step to the config & cleanup

7b8cb20

Set default preference values

497a527

Cleanup

2742e4f

Merge branch 'master' into feature/dynamic-preferences

bf3536f

Cleanup

b936a98

Updated summary details

46eb2e3

Cleanup

360f69e

dominikx96 requested a review from slowbot April 23, 2021 14:13

dominikx96 self-assigned this Apr 23, 2021

dominikx96 added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Apr 23, 2021

exygy-dev temporarily deployed to bloom-refere-feature-dy-py2wdr April 23, 2021 14:13 Inactive

accesslint bot suggested changes Apr 23, 2021

View reviewed changes

ui-components/src/helpers/preferences.tsx

return (

<>

<Select

This comment was marked as resolved.

Sign in to view

dominikx96 requested a review from kathyccheng April 23, 2021 14:16

Updating preferences page styles

46d7efa

Removed old translations

a94a9bb

exygy-dev temporarily deployed to bloom-refere-feature-dy-lltdck April 27, 2021 16:59 Inactive

accesslint bot approved these changes Apr 27, 2021

View reviewed changes

Merge branch 'master' into feature/dynamic-preferences

b851119

exygy-dev temporarily deployed to bloom-refere-feature-dy-wd4cth April 28, 2021 07:07 Inactive

accesslint bot approved these changes Apr 28, 2021

View reviewed changes

Removed old displaced preference page

fbb827d

exygy-dev temporarily deployed to bloom-refere-feature-dy-7odust April 28, 2021 07:12 Inactive

accesslint bot approved these changes Apr 28, 2021

View reviewed changes

Added missing translation

8c5427d

exygy-dev temporarily deployed to bloom-refere-feature-dy-jyjwge April 28, 2021 07:44 Inactive

accesslint bot approved these changes Apr 28, 2021

View reviewed changes

Fixed broken tests

aaa1764

exygy-dev temporarily deployed to bloom-refere-feature-dy-vaopzy April 28, 2021 08:11 Inactive

accesslint bot approved these changes Apr 28, 2021

View reviewed changes

Updated tests to load listing with 2 preferences

65fbe64

exygy-dev temporarily deployed to bloom-refere-feature-dy-vuwwki April 28, 2021 09:18 Inactive

accesslint bot approved these changes Apr 28, 2021

View reviewed changes

emilyjablonski approved these changes Apr 28, 2021

View reviewed changes

jaredcwhite requested changes Apr 28, 2021

View reviewed changes

dominikx96 added 2 commits April 29, 2021 09:59

Added more information about function

5443312

Cleanup

5dc694c

exygy-dev temporarily deployed to bloom-refere-feature-dy-eu2hw9 April 29, 2021 08:32 Inactive

accesslint bot approved these changes Apr 29, 2021

View reviewed changes

dominikx96 requested a review from jaredcwhite April 29, 2021 08:38

dominikx96 merged commit 0735935 into master Apr 29, 2021

adriencyberspace mentioned this pull request Apr 27, 2022

1167/not found UI #2698

Closed

20 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/dynamic preferences #1167

Feature/dynamic preferences #1167

dominikx96 commented Apr 23, 2021 •

edited

Loading

accesslint bot left a comment

This comment was marked as resolved.

kathyccheng commented Apr 23, 2021

accesslint bot left a comment

accesslint bot left a comment

accesslint bot left a comment

netlify bot commented Apr 28, 2021 •

edited

Loading

dominikx96 commented Apr 28, 2021

accesslint bot left a comment

accesslint bot left a comment

accesslint bot left a comment

dominikx96 commented Apr 28, 2021

jaredcwhite left a comment

jaredcwhite Apr 28, 2021

dominikx96 Apr 29, 2021

jaredcwhite Apr 28, 2021

jaredcwhite Apr 28, 2021

dominikx96 Apr 29, 2021

jaredcwhite Apr 28, 2021

jaredcwhite Apr 28, 2021

dominikx96 Apr 29, 2021

jaredcwhite Apr 29, 2021

accesslint bot left a comment


		const watchPreferences = watch(allOptionFieldNames)

		function uncheckPreference(metaKey: string, options: FormMetadataOptions[]) {

Feature/dynamic preferences #1167

Feature/dynamic preferences #1167

Conversation

dominikx96 commented Apr 23, 2021 • edited Loading

accesslint bot left a comment

Choose a reason for hiding this comment

This comment was marked as resolved.

kathyccheng commented Apr 23, 2021

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

netlify bot commented Apr 28, 2021 • edited Loading

dominikx96 commented Apr 28, 2021

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

dominikx96 commented Apr 28, 2021

jaredcwhite left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

accesslint bot left a comment

Choose a reason for hiding this comment

dominikx96 commented Apr 23, 2021 •

edited

Loading

netlify bot commented Apr 28, 2021 •

edited

Loading