Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make additional eligibility sections optional #1213

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

emilyjablonski
Copy link
Collaborator

Following QA on the Nova listing and their ask to remove the credit history and rental history sections for lack of language, this PR makes all three of the additional eligibility sections optional (previously it required an empty string and the headers would still appear). Ran this past Kathy 👍

@exygy-dev exygy-dev temporarily deployed to bloom-refere-fix-nova-q-19swha May 6, 2021 16:25 Inactive
@netlify
Copy link

netlify bot commented May 6, 2021

Deploy preview for clever-edison-cd22c1 ready!

Built with commit b94cf15

https://deploy-preview-1213--clever-edison-cd22c1.netlify.app

Copy link
Collaborator

@jaredcwhite jaredcwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@emilyjablonski emilyjablonski merged commit 0da9a3e into master May 10, 2021
@emilyjablonski emilyjablonski deleted the fix/nova-qa branch May 10, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants