Fix/cypress wait #1262
Merged
Fix/cypress wait #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for clever-edison-cd22c1 ready! 🔨 Explore the source changes: 1294b08 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/60ae1028e4aaf1000875648e 😎 Browse the preview: https://deploy-preview-1262--clever-edison-cd22c1.netlify.app |
|
LGTM! |
willrlin
referenced
this pull request
in CityOfDetroit/bloom
Jun 9, 2021
* Put port in the url * Increased node max. memory limit * Change wait-on url * Run backend before build * Run build script from the package.json * Restore some old parts * Updated broken test * Updated changelog Co-authored-by: dominikx96 <dominik@airnauts.com>
willrlin
referenced
this pull request
in CityOfDetroit/bloom
Jun 9, 2021
This reverts commit 40a63b9.
willrlin
referenced
this pull request
in CityOfDetroit/bloom
Jun 9, 2021
This reverts commit 40a63b9.
YazeedLoonat
pushed a commit
to YazeedLoonat/bloom
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue
#1257
Addresses # (issue)
Description
I tried to follow all CircleCI steps in my local setup and noticed in the build section in the config.yml command:
yarn build:app:public- BUT we just set up backend without running it. It means - the build doesn’t contain all the necessary pages which come from the listing so this build is not correct.I moved the build command into sites/public
package.json, thenyarn startcommand should run after build.Also fixed broken
MyApplicationstest - it requires to wait for route change after successful login.Type of change
How Can This Be Tested/Reviewed?
Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration
Checklist: