1742/relocate formatIncome

[emilyjablonski]

Pull Request Template

Issue

Addresses #1742

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

Initial issue was to remove business logic from formatIncome since it uses backend types and lived in ui-components, but I just don't think this should live in ui-components. I moved it to partners helpers.

Type of change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Prototype/POC (not to merge)
• This change is a refactor/address technical debt
• This change requires a documentation update
• This change requires a SQL Script

How Can This Be Tested/Reviewed?

Just moved the same function :) It's only used in paper applications on partners.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have updated the changelog to include a description of my changes

[netlify]

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 499181d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/612fb6bf980dea0007eb0260

😎 Browse the preview: https://deploy-preview-1744--dev-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 499181d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/612fb6bfe237cc00090b16b6

😎 Browse the preview: https://deploy-preview-1744--dev-partners-bloom.netlify.app

[netlify]

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 499181d

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/612fb6bf9a294d00081c0ff3

😎 Browse the preview: https://deploy-preview-1744--dev-storybook-bloom.netlify.app

[seanmalbert]

This looks good, @emilyjablonski. Before merging this, can you create an issue to add unit testing to partners and add back in the formatIncome tests and have the partner unit tests run in circleci.

[emilyjablonski]

#1786 👍

[netlify]

✔️ Deploy Preview for clever-edison-cd22c1 ready!

🔨 Explore the source changes: 499181d

🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/612fb6bf60c466000843a568

😎 Browse the preview: https://deploy-preview-1744--clever-edison-cd22c1.netlify.app