-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1573/remove dependencies from listings group #1752
1573/remove dependencies from listings group #1752
Conversation
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 3ff69c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6126ade247e89e00086ed62a 😎 Browse the preview: https://deploy-preview-1752--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 3ff69c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6126ade2903e4c0007ff9eaa 😎 Browse the preview: https://deploy-preview-1752--dev-storybook-bloom.netlify.app |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 3ff69c8 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6126ade20d6f53000708c8ba 😎 Browse the preview: https://deploy-preview-1752--dev-bloom.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good update, @emilyjablonski. This will make it easier to change what we're passing in for the count. When we add pagination, we'll want to pass in the total count. We have this information now on meta, but requires more changes that I think are outside the scope of this work.
…dependencies-from-listings-group
Pull Request Template
Issue
Addresses #1752
Description
Removes backend references and also changes the component to accept children instead of listings.
Type of change
How Can This Be Tested/Reviewed?
Check out the Story to ensure all is behaving as expected.
Checklist: