-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1774 preferred unit (same as one from Sean's fork) #1787
Conversation
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 2f99546 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/613a63e2ae5cf80008e5dc65 😎 Browse the preview: https://deploy-preview-1787--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 2f99546 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/613a63e2fd5250000710c379 😎 Browse the preview: https://deploy-preview-1787--dev-bloom.netlify.app |
✔️ Deploy Preview for clever-edison-cd22c1 ready! 🔨 Explore the source changes: 8d4c0f5 🔍 Inspect the deploy log: https://app.netlify.com/sites/clever-edison-cd22c1/deploys/613866877dc61c00086e8cb7 😎 Browse the preview: https://deploy-preview-1787--clever-edison-cd22c1.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 2f99546 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/613a63e2819cbf000840ee83 😎 Browse the preview: https://deploy-preview-1787--dev-storybook-bloom.netlify.app |
@seanmalbert I updated the frontend for the public & partners app. It looks like the backend tests are failing, can you check it before merge? |
@dominikx96 , all tests are passing now. |
@emilyjablonski , can you review when you get a chance. Thank you! |
@emilyjablonski I sorted these values in Partners, also tried to prevent undefined error (but it's probably seeds problem), can you check again? :) |
Needs to be rebased. |
6d38de1
to
2f99546
Compare
* backend changes for preferredUnit -> UnitType[] * Fix code style issues with Prettier * Update unit type translations * Prevent unit name undefined * Create helper to extract unique unit types * Update public app to use new unit types structure * Refactor unit helper * Update form to send array of objects with id property * Update partners form to support new * Update e2e test * Fix code style issues with Prettier * Fix test * Update unit using id from the listing * Fix code style issues with Prettier * Update terms test * Fix code style issues with Prettier * Add removed command * Fix test * Fix code style issues with Prettier * Update changelog * backend updates to fix tests and cleanup * Fix code style issues with Prettier * Sort unitType values and fix undefined issue * Fix code style issues with Prettier Co-authored-by: Lint Action <lint-action@samuelmeuli.com> Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Issue
Addresses #1774
Description
Updates both frontend and backend to save
unitType
id's (they come from the listingunits
property) instead of strings likestudio
in thepreferredUnit
property (application).Type of change
How Can This Be Tested/Reviewed?
Create a new listing with different unit types (e.g studio, 4 bedrooms), then post an application using public and partners. Check if both applications showing properly in partners in the
Household Details > Preferred Unit Sizes
section.Checklist: