Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit summary amiPercentage to int #1797

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Migrate unit summary amiPercentage to int #1797

merged 3 commits into from
Sep 13, 2021

Conversation

avaleske
Copy link
Contributor

@avaleske avaleske commented Sep 7, 2021 •
edited
Loading

Pull Request Template

Issue

Migrate unit summary AMI Percentage field to integer, to support filtering

Addresses CityOfDetroit#478

  • This change addresses only certain aspects of the issue

Description

Migrate the amiPercentage column on the unit summary table to an integer, so we can filter based on it.

Type of change

  • New feature (non-breaking change which adds functionality)

How Can This Be Tested/Reviewed?

  • Try running the migration, and make sure the site still starts. The field is unused so far, so there should be no data issues.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes

@avaleske @lint-action
Migrate unitSummary amiPercentage column to int (#534)
fad53cc 
* add migration for ami percentage column

* Fix code style issues with Prettier

* fix validation for amiPercentage

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
@netlify
Copy link

netlify bot commented Sep 7, 2021 •
edited
Loading

❌ Deploy Preview for dev-bloom failed.

🔨 Explore the source changes: d0a8f9e

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/613f695a917cbe0008474e52

@netlify
Copy link

netlify bot commented Sep 7, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: d0a8f9e

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/613f695a4e5f430007ea912c

😎 Browse the preview: https://deploy-preview-1797--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 7, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: d0a8f9e

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/613f695adff72100073c742b

😎 Browse the preview: https://deploy-preview-1797--dev-storybook-bloom.netlify.app

@avaleske
Copy link
Contributor Author

avaleske commented Sep 7, 2021

@seanmalbert and @willrlin for visibility

This was referenced Sep 7, 2021
Merged
Closed
@avaleske
Copy link
Contributor Author

avaleske commented Sep 7, 2021

Also looks like linters are still failing on forks.

@avaleske
Copy link
Contributor Author

avaleske commented Sep 7, 2021

And the failing test is a rate-limiting issue.

@seanmalbert
Copy link
Collaborator

@pbn4 , can you please review.

seanmalbert
seanmalbert approved these changes Sep 13, 2021
View reviewed changes
Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @avaleske, looks good!

@seanmalbert seanmalbert merged commit 71a1a49 into bloom-housing:dev Sep 13, 2021
@seanmalbert seanmalbert deleted the contribute/migrate-unit-summary-ami-percentage-to-int branch September 13, 2021 15:38
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@avaleske @lint-action @seanmalbert
Migrate unit summary amiPercentage to int (bloom-housing#1797)
fe403a2 
* Migrate unitSummary amiPercentage column to int (#534)

* add migration for ami percentage column

* Fix code style issues with Prettier

* fix validation for amiPercentage

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

* update changelog

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: seanmalbert <smabert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalbert seanmalbert seanmalbert approved these changes

@pbn4 pbn4 Awaiting requested review from pbn4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@avaleske @seanmalbert