Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isPartner filter to GET /user/list endpoint #1830

Merged
merged 5 commits into from
Sep 21, 2021
Merged

Add isPartner filter to GET /user/list endpoint #1830

merged 5 commits into from
Sep 21, 2021

Conversation

pbn4
Copy link
Contributor

@pbn4 pbn4 commented Sep 15, 2021 •
edited
Loading

Pull Request Template

Issue

Addresses # (#1651)

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Adds isPartner filter to GET /user/list endpoint.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Sep 15, 2021 •
edited
Loading

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 0767aa0

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6148a7387d9144000792e19e

😎 Browse the preview: https://deploy-preview-1830--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 15, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 0767aa0

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6148a73803999a0007a8205e

😎 Browse the preview: https://deploy-preview-1830--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 15, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 0767aa0

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6148a7386f85b70007eb9ba2

😎 Browse the preview: https://deploy-preview-1830--dev-partners-bloom.netlify.app

dominikx96
dominikx96 approved these changes Sep 15, 2021
View reviewed changes
Copy link
Collaborator

@dominikx96 dominikx96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbn4 works as expected 👍

seanmalbert
seanmalbert reviewed Sep 21, 2021
View reviewed changes
Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dominikx96 and @pbn4 , I think this looks good. The only thing I think we might want to add, and this is for @pbn4 , is that in the user list endpoint, we probably also want to filter the users based on the jurisdiction of the user making the request. So that if I'm an admin for Alameda and I'm looking at the user's table, I don't see users for other jurisdiction like San Jose. This could also be done in separate PR, if we don't want to add more to this PR.

@dominikx96 dominikx96 merged commit 473a1f7 into dev Sep 21, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@pbn4 @dominikx96 @lint-action
Add isPartner filter to GET /user/list endpoint (bloom-housing#1830)
005ba59 
* Add isPartner filter to GET /user/list endpoint

* Fix pagination issue on items per page change

* Filter users by isPartner

* Fix code style issues with Prettier

Co-authored-by: Dominik Barcikowski <dominik@airnauts.com>
Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalbert seanmalbert seanmalbert left review comments

@dominikx96 dominikx96 dominikx96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pbn4 @seanmalbert @dominikx96 @lint-action