1653/user invite flow frontend #1857

dominikx96 · 2021-09-21T15:09:43Z

Pull Request Template

Issue

Addresses #1653

This change addresses the issue in full
This change addresses only certain aspects of the issue
This change is a dependency for another issue
This change has a dependency from another issue

Description

Adds the "Add user" drawer with form.

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Prototype/POC (not to merge)
This change is a refactor/address technical debt
This change requires a documentation update
This change requires a SQL Script

How Can This Be Tested/Reviewed?

Use the newly created form to add a new user, then check if a user exists in the user table.
You can also test behavior if an email already exists (it should show a proper alert with an error message).

Desktop View
Mobile View
Test A
Test B

Checklist:

netlify · 2021-09-21T15:09:50Z

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: f9d3483

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/6153390bf84b640007b521d6

😎 Browse the preview: https://deploy-preview-1857--dev-partners-bloom.netlify.app

netlify · 2021-09-21T15:09:50Z

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: f9d3483

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/6153390b59e7770007975860

😎 Browse the preview: https://deploy-preview-1857--dev-bloom.netlify.app

netlify · 2021-09-21T15:09:51Z

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: f9d3483

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/6153390b95d44b0007b31ef1

😎 Browse the preview: https://deploy-preview-1857--dev-storybook-bloom.netlify.app

emilyjablonski

Small typo in the e-mail To complete your account creation, please the link below: just need the word click.
The e-mail subject should be Welcome to the Partners Portal and the content is a little different, but it's in the issue :)

emilyjablonski · 2021-09-23T19:47:33Z

When I click "Confirm my Account" from the email I'm taken to the partners sign-in page but I don't have a password yet so I'm not sure what the flow there should be. Maybe the "create a password" flow is a separate issue?

emilyjablonski · 2021-09-23T19:49:02Z

sites/partners/pages/users/index.tsx

  /* Fetch user list */
  const { data: userList } = useUserList({
    page: currentPage,
    limit: itemsPerPage,
  })

+  /* Fetch listings */


@seanmalbert Might eventually be worth a new query that only retrieves name, jurisdiction, and ID

emilyjablonski · 2021-09-23T19:49:55Z

sites/partners/src/users/FormUserAdd.tsx

+      lastName,
+      email,
+      roles,
+      leasingAgentInListings: leasingAgentInListings,


NB but don't need the colons here

They're automagically added by linter ;D

emilyjablonski · 2021-09-27T19:18:34Z

I'm curious about my two comments above still - the content and subject of the email is not quite right and the fact that I am redirected to sign-in without having set up a password (which is maybe a later ticket?)

kathyccheng · 2021-09-27T19:24:14Z

@emilyjablonski Flow for leasing agents to update their password is in a separate issue, #1654

Email copy from issues re-pasted below for reference :)

Email Copy

From: no-reply@housingbayarea.org
Subject Line: Welcome to the Partners Portal

Hello Name,

Welcome to the the Partners Portal on [URL]. You will now be able to manage listings and applications that you are a part of from one centralized location.

To complete your account creation, please click the link below:

Confirm my account

Thank you,
Alameda County - Housing and Community Development (HCD) Department

dominikx96 · 2021-09-28T15:42:30Z

@emilyjablonski I updated translations and resolved conflict in the FieldGroup component, ready for review :)

emilyjablonski · 2021-09-28T15:42:37Z

backend/core/src/migration/1631110073158-add-null-jurisdiction-translation.ts

      inviteMessage:
-        "Thank you for setting up your account on %{appUrl}. It will now be easier for you to start, save, and submit online applications for listings that appear on the site.",
-      toCompleteAccountCreation: "To complete your account creation, please the link below:",
+        "Welcome to the the Partners Portal on %{appUrl}. You will now be able to manage listings and applications that you are a part of from one centralized location.",


One small typo here the the

Thanks, fixed! :)

emilyjablonski · 2021-09-28T15:43:28Z

I get a 400 if I try to add a user who already exists which I think is probably okay, but it means if anyone has ever created an account on the public site (and maybe even parters?) then we can't add them as a user on the partners site with the same email.

emilyjablonski

LGTM apart from the existing user piece and it sounds like that's a separate PR :)

seanmalbert · 2021-09-29T03:50:34Z

@pbn4 , see Emily's comment above, can you fix the issue causing the 400 bad request to be thrown when a user who already exists in the system gets added. A more useful response is probably all that's needed, something like A user with that email already exists.

* Update field props * Update translation * Fix alert style * Update hook to support 'all' option * Create user add form * Make user model dob field optional * Update changelog * Drop NOT NULL constraint in user model DOB column * Fix code style issues with Prettier * Fix type issue * Fix typos in emails * Update translations * Fix typo Co-authored-by: Michal Plebanski <michalp@airnauts.com> Co-authored-by: Lint Action <lint-action@samuelmeuli.com>

dominikx96 added 5 commits September 21, 2021 17:06

Update field props

65c2326

Update translation

33b74f4

Fix alert style

cba32fe

Update hook to support 'all' option

921d2a2

Create user add form

7790246

dominikx96 added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Sep 21, 2021

pbn4 and others added 5 commits September 22, 2021 15:34

Make user model dob field optional

5e1ceba

Update changelog

2c4ffcc

Drop NOT NULL constraint in user model DOB column

639c4d1

Fix code style issues with Prettier

5dfaa9b

Fix type issue

9dcd9a7

dominikx96 added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” ready for review labels Sep 23, 2021

dominikx96 requested a review from emilyjablonski September 23, 2021 12:16

emilyjablonski requested changes Sep 23, 2021

View reviewed changes

emilyjablonski reviewed Sep 23, 2021

View reviewed changes

Fix typos in emails

3981aba

dominikx96 added 2 commits September 28, 2021 17:22

Update translations

125c363

Merge branch 'dev' into 1653/user-invite-flow-frontend

126fd2a

emilyjablonski reviewed Sep 28, 2021

View reviewed changes

Fix typo

f9d3483

emilyjablonski approved these changes Sep 28, 2021

View reviewed changes

dominikx96 merged commit 69199cb into dev Sep 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1653/user invite flow frontend #1857

1653/user invite flow frontend #1857

dominikx96 commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

emilyjablonski left a comment

emilyjablonski commented Sep 23, 2021

emilyjablonski Sep 23, 2021

emilyjablonski Sep 23, 2021

dominikx96 Sep 24, 2021

emilyjablonski commented Sep 27, 2021 •

edited

Loading

kathyccheng commented Sep 27, 2021

dominikx96 commented Sep 28, 2021

emilyjablonski Sep 28, 2021

dominikx96 Sep 28, 2021

emilyjablonski commented Sep 28, 2021 •

edited

Loading

emilyjablonski left a comment

seanmalbert commented Sep 29, 2021

1653/user invite flow frontend #1857

1653/user invite flow frontend #1857

Conversation

dominikx96 commented Sep 21, 2021 • edited Loading

Pull Request Template

Issue

Description

Type of change

How Can This Be Tested/Reviewed?

Checklist:

netlify bot commented Sep 21, 2021 • edited Loading

netlify bot commented Sep 21, 2021 • edited Loading

netlify bot commented Sep 21, 2021 • edited Loading

emilyjablonski left a comment

Choose a reason for hiding this comment

emilyjablonski commented Sep 23, 2021

emilyjablonski Sep 23, 2021

Choose a reason for hiding this comment

emilyjablonski Sep 23, 2021

Choose a reason for hiding this comment

dominikx96 Sep 24, 2021

Choose a reason for hiding this comment

emilyjablonski commented Sep 27, 2021 • edited Loading

kathyccheng commented Sep 27, 2021

dominikx96 commented Sep 28, 2021

emilyjablonski Sep 28, 2021

Choose a reason for hiding this comment

dominikx96 Sep 28, 2021

Choose a reason for hiding this comment

emilyjablonski commented Sep 28, 2021 • edited Loading

emilyjablonski left a comment

Choose a reason for hiding this comment

seanmalbert commented Sep 29, 2021

dominikx96 commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

netlify bot commented Sep 21, 2021 •

edited

Loading

emilyjablonski commented Sep 27, 2021 •

edited

Loading

emilyjablonski commented Sep 28, 2021 •

edited

Loading