Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): add jurisidction relation to ReservedCommunittType Entity #1889

Merged
merged 6 commits into from
Oct 5, 2021
Merged

feat(backend): add jurisidction relation to ReservedCommunittType Entity #1889

merged 6 commits into from
Oct 5, 2021

Conversation

pbn4
Copy link
Contributor

@pbn4 pbn4 commented Sep 28, 2021 •
edited
Loading

Pull Request Template

Issue

Addresses # (#1839 )

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Add jurisdiction relation to ReservedCommunityType entity.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Please describe the tests that you ran to verify your changes. Provide instructions so we can review. Please also list any relevant details for your test configuration

  • Desktop View
  • Mobile View
  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Sep 28, 2021 •
edited
Loading

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: f4820ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615bc5a96012b60007bb9e04

😎 Browse the preview: https://deploy-preview-1889--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 28, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: f4820ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615bc5a91de52d0008b860a8

😎 Browse the preview: https://deploy-preview-1889--dev-partners-bloom.netlify.app

@pbn4 pbn4 force-pushed the 1839/jurisdiction_community_types branch from af79552 to c6166a5 Compare September 28, 2021 18:04
@netlify
Copy link

netlify bot commented Sep 28, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: f4820ca

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615bc5a910595100082cb207

😎 Browse the preview: https://deploy-preview-1889--dev-storybook-bloom.netlify.app

@pbn4 pbn4 force-pushed the 1839/jurisdiction_community_types branch from 63f3220 to 97ff93e Compare September 30, 2021 06:49
@seanmalbert seanmalbert merged commit 9b0fe73 into dev Oct 5, 2021
seanmalbert added a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@pbn4 @lint-action @seanmalbert
feat(backend): add jurisidction relation to ReservedCommunittType Ent…
a7aad77 
…ity (bloom-housing#1889)

* feat(backend): add jurisdiction relation to ReservedCommunityType entity

* Fix code style issues with Prettier

* fix(backend): change reserved community type jurisidction relation migration Alameda by default

* fix: updates import-helper reservedComunityType

* test: adds check for jurisdiction id in test

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Co-authored-by: Sean Albert <smabert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanmalbert seanmalbert seanmalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pbn4 @seanmalbert @lint-action