-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support PDF uploads or webpage links for building selection criteria #1893
Conversation
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 6689db5 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615fd300a92c2c000850dcff 😎 Browse the preview: https://deploy-preview-1893--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 6689db5 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615fd300a0ed8f00087c6dd6 😎 Browse the preview: https://deploy-preview-1893--dev-storybook-bloom.netlify.app |
❌ Deploy Preview for dev-bloom failed. 🔨 Explore the source changes: 6689db5 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615fd300d30f510008b02641 |
…sing/bloom into 1755/building-criteria-uploads
@slowbot I'd like to get your take on how I worded the external webpage vs. PDF upload nomenclature. I think there was some prior confusion over whether an external URL would link to a PDF hosted elsewhere vs. an actual website, so I tried to word things to make it clear PDFs should always be uploaded. Let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slowbot All right I implemented the table (request 2). As far the issue of the data disappearing, I wasn't able to recreate that. If you're still seeing the issue, I'll try to investigate further. |
@jaredcwhite I'm still seeing the issue on the deploy branch but that may be outdated. Do you have an updated deploy branch I can use to test? |
@jaredcwhite and @slowbot, the deploy branch won't have the database changes required for this to save properly, since those still point to the dev db. Since @pbn4 approved the backend and if it looks good visually, then we can merge this and have it QAd on dev. Sound good? |
…teria (bloom-housing#1893) * feat: Allow PDF uploads for selection criteria * feat: Allow selection criteria URLs, show in Detail view * Clean up comments * Fix code style issues with Prettier * fix: use shared PDF helper function * fix: type error * fix: test condition * Update Changelog with bloom-housing#1893 * feat: use table for detail view of selection criteria * Update dtos Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Issue
Addresses #1755
Description
For listings management, this PR add the ability to specify either (a) a PDF upload, or (b) a link to an external webpage with information for building selection criteria.
Type of change
How Can This Be Tested/Reviewed?
Look under the Additional Eligibility Rules section when adding/editing a listing.
Checklist:
yarn generate:client
if I made backend changes