Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support PDF uploads or webpage links for building selection criteria #1893

Merged
merged 13 commits into from
Oct 8, 2021

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Sep 28, 2021

Issue

Addresses #1755

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

For listings management, this PR add the ability to specify either (a) a PDF upload, or (b) a link to an external webpage with information for building selection criteria.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Look under the Additional Eligibility Rules section when adding/editing a listing.

  • Desktop View
  • Mobile View

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 6689db5

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615fd300a92c2c000850dcff

😎 Browse the preview: https://deploy-preview-1893--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 28, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 6689db5

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615fd300a0ed8f00087c6dd6

😎 Browse the preview: https://deploy-preview-1893--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Sep 28, 2021

❌ Deploy Preview for dev-bloom failed.

🔨 Explore the source changes: 6689db5

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615fd300d30f510008b02641

@jaredcwhite jaredcwhite changed the title Support PDF uploads or webpage links for building selection criteria feat: Support PDF uploads or webpage links for building selection criteria Sep 28, 2021
@jaredcwhite
Copy link
Collaborator Author

@slowbot I'd like to get your take on how I worded the external webpage vs. PDF upload nomenclature. I think there was some prior confusion over whether an external URL would link to a PDF hosted elsewhere vs. an actual website, so I tried to word things to make it clear PDFs should always be uploaded. Let me know what you think!
https://deploy-preview-1893--dev-partners-bloom.netlify.app/listings/add

Copy link
Collaborator

@slowbot slowbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Uploading file does not persist after save as draft
    image
    image
  2. Can we use the table view here rather than printing the url?
    image
    image

@jaredcwhite
Copy link
Collaborator Author

jaredcwhite commented Sep 30, 2021

@slowbot All right I implemented the table (request 2). As far the issue of the data disappearing, I wasn't able to recreate that. If you're still seeing the issue, I'll try to investigate further.

@slowbot
Copy link
Collaborator

slowbot commented Oct 5, 2021

@jaredcwhite I'm still seeing the issue on the deploy branch but that may be outdated. Do you have an updated deploy branch I can use to test?

@seanmalbert
Copy link
Collaborator

@jaredcwhite I'm still seeing the issue on the deploy branch but that may be outdated. Do you have an updated deploy branch I can use to test?

@jaredcwhite and @slowbot, the deploy branch won't have the database changes required for this to save properly, since those still point to the dev db. Since @pbn4 approved the backend and if it looks good visually, then we can merge this and have it QAd on dev. Sound good?

@jaredcwhite jaredcwhite merged commit 8514b43 into dev Oct 8, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
…teria (bloom-housing#1893)

* feat: Allow PDF uploads for selection criteria

* feat: Allow selection criteria URLs, show in Detail view

* Clean up comments

* Fix code style issues with Prettier

* fix: use shared PDF helper function

* fix: type error

* fix: test condition

* Update Changelog with bloom-housing#1893

* feat: use table for detail view of selection criteria

* Update dtos

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants