Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: required labels on listings management fields #1924

Merged
merged 5 commits into from
Oct 8, 2021
Merged

feat: required labels on listings management fields #1924

merged 5 commits into from
Oct 8, 2021

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Oct 4, 2021 •
edited
Loading

Pull Request Template

Issue

Addresses #1580

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Add required notes to the required fields in listings management. Had to add a few optional props to the field components.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/address technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Open listings management and ensure before you've submitted that it looks good and then try to publish without entering anything and ensure the notes still look good when you also have error messages.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes

@netlify
Copy link

netlify bot commented Oct 4, 2021 •
edited
Loading

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 07526c7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/615fb40e9a82a300085ac981

😎 Browse the preview: https://deploy-preview-1924--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 4, 2021 •
edited
Loading

❌ Deploy Preview for dev-bloom failed.

🔨 Explore the source changes: 07526c7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/615fb40d04b1e10009e8984d

@netlify
Copy link

netlify bot commented Oct 4, 2021 •
edited
Loading

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 07526c7

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/615fb40ded839d0007f1308b

😎 Browse the preview: https://deploy-preview-1924--dev-partners-bloom.netlify.app

accesslint[bot]
accesslint bot suggested changes Oct 4, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

ui-components/src/forms/Select.tsx Outdated
{label}
</label>
<div className={controlClassName}>
<select
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this element is missing an accessible name or label. That makes it hard for people using screen readers or voice control to use the control.

accesslint[bot]
accesslint bot approved these changes Oct 4, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Oct 5, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@slowbot
Copy link
Collaborator

slowbot commented Oct 5, 2021 •
edited
Loading

@emilyjablonski

Can we:

  1. Add add a legend of form group label to residence address?
  2. Add one "required to publish" label for the entire residence address fieldgroup?

image

@emilyjablonski
Copy link
Collaborator Author

@slowbot sure thing

@emilyjablonski emilyjablonski added wip This PR is not ready for review, do not review it's a “Work In Progress” and removed ready for review labels Oct 5, 2021
accesslint[bot]
accesslint bot approved these changes Oct 6, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@emilyjablonski emilyjablonski added ready for review and removed wip This PR is not ready for review, do not review it's a “Work In Progress” labels Oct 6, 2021
@slowbot
Copy link
Collaborator

slowbot commented Oct 7, 2021 •
edited
Loading

@emilyjablonski Can we add a label to the default state of photos and units similar to the mockups so we can associate error messages to the labels?

image

@emilyjablonski
Copy link
Collaborator Author

Updated! :)

accesslint[bot]
accesslint bot approved these changes Oct 7, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

accesslint[bot]
accesslint bot approved these changes Oct 8, 2021
View reviewed changes
Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 You fixed the issue(s)! Great work.

@emilyjablonski emilyjablonski merged commit 0a2e2da into dev Oct 8, 2021
@emilyjablonski emilyjablonski deleted the 1580/required-label branch October 8, 2021 14:15
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
@emilyjablonski
feat: required labels on listings management fields (bloom-housing#1924)
9458226
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredcwhite jaredcwhite jaredcwhite approved these changes

@accesslint accesslint[bot] accesslint approved these changes

@slowbot slowbot Awaiting requested review from slowbot

Assignees

@slowbot slowbot

@jaredcwhite jaredcwhite

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilyjablonski @slowbot @jaredcwhite