Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in the paper applications table #1965

Merged
merged 2 commits into from
Oct 19, 2021

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Oct 8, 2021

Pull Request Template

Issue

Addresses #1899

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Languages will show now in the paper applications table in the Partners Listing Form.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/addresses technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes
  • I have exported any new pieces in ui-components

@jaredcwhite jaredcwhite added the wip This PR is not ready for review, do not review it's a “Work In Progress” label Oct 8, 2021
@netlify
Copy link

netlify bot commented Oct 8, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 75ed1db

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/616edcea72a39500074fe4c9

😎 Browse the preview: https://deploy-preview-1965--dev-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 75ed1db

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/616edcea4289c1000852c36f

😎 Browse the preview: https://deploy-preview-1965--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 8, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 75ed1db

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/616edcea19e43e000795ab4b

😎 Browse the preview: https://deploy-preview-1965--dev-partners-bloom.netlify.app

@seanmalbert
Copy link
Collaborator

@jaredcwhite , there's a wip label on this, but if it's just the change you have here, then you're good to merge.

@jaredcwhite jaredcwhite force-pushed the 1899/fix-paper-application-uploads branch from 194b92d to 75ed1db Compare October 19, 2021 14:57
@jaredcwhite jaredcwhite merged commit a342772 into dev Oct 19, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* fix: typo in the paper applications table

* Update Changelog with bloom-housing#1965
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip This PR is not ready for review, do not review it's a “Work In Progress”
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants