-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): add Program entity #1968
Conversation
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 634ecf4 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61718eb8772aa40007b2d892 😎 Browse the preview: https://deploy-preview-1968--dev-storybook-bloom.netlify.app |
❌ Deploy Preview for dev-partners-bloom failed. 🔨 Explore the source changes: 634ecf4 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61718eb8b02f2200083decd2 |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 634ecf4 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61718eb8a2225800072fe1d1 😎 Browse the preview: https://deploy-preview-1968--dev-bloom.netlify.app |
52b717a
to
12f0fd4
Compare
233d66f
to
15fd904
Compare
@seanmalbert Can I get your feedback here? This review has been blocking me on the Program ticket for a bit |
0e58cb0
to
b2f42fa
Compare
Addresses #2000 too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pbn4 ,
This looks good, but take a look at my feedback for the preference update PR, particularly in regard to how we're handling pages. Depending on how we handle that, this may need to get updated as well.
@pbn4 , |
* feat(backend): add Program entity * Fix code style issues with Prettier * feat(backend): Add programs to application entity * Fix code style issues with Prettier * feat(backend): Add Program seeds (bloom-housing#2034) * feat(backend): Remove page from program entity * Fix code style issues with Prettier Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Pull Request Template
Issue
Addresses #1867
Description
This change adds Program entity and a relation to Listing (Many to Many) and Jurisdiction (Many to Many).
Listings management frontend must be updated because right now ListingCreateDto and ListingUpdateDto require at least an empty ListingPrograms array. cc: @emilyjablonski @dominikx96 @seanmalbert
Type of change
How Can This Be Tested/Reviewed?
Provide instructions so we can review.
Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.
Checklist:
yarn generate:client
if I made backend changes