Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): add Program entity #1968

Merged
merged 8 commits into from
Oct 22, 2021
Merged

Conversation

pbn4
Copy link
Contributor

@pbn4 pbn4 commented Oct 11, 2021

Pull Request Template

Issue

Addresses #1867

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

This change adds Program entity and a relation to Listing (Many to Many) and Jurisdiction (Many to Many).

Listings management frontend must be updated because right now ListingCreateDto and ListingUpdateDto require at least an empty ListingPrograms array. cc: @emilyjablonski @dominikx96 @seanmalbert

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Prototype/POC (not to merge)
  • This change is a refactor/addresses technical debt
  • This change requires a documentation update
  • This change requires a SQL Script

How Can This Be Tested/Reviewed?

Provide instructions so we can review.

Describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have updated the changelog to include a description of my changes
  • I have run yarn generate:client if I made backend changes
  • I have exported any new pieces in ui-components

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 634ecf4

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61718eb8772aa40007b2d892

😎 Browse the preview: https://deploy-preview-1968--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 11, 2021

❌ Deploy Preview for dev-partners-bloom failed.

🔨 Explore the source changes: 634ecf4

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/61718eb8b02f2200083decd2

@netlify
Copy link

netlify bot commented Oct 11, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 634ecf4

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/61718eb8a2225800072fe1d1

😎 Browse the preview: https://deploy-preview-1968--dev-bloom.netlify.app

@pbn4 pbn4 force-pushed the 1867/jurisdiction_program_entity branch from 52b717a to 12f0fd4 Compare October 11, 2021 15:17
@pbn4 pbn4 requested a review from seanmalbert October 11, 2021 15:17
@pbn4 pbn4 marked this pull request as ready for review October 11, 2021 15:18
@pbn4 pbn4 force-pushed the 1867/jurisdiction_program_entity branch from 233d66f to 15fd904 Compare October 12, 2021 12:16
@emilyjablonski
Copy link
Collaborator

@seanmalbert Can I get your feedback here? This review has been blocking me on the Program ticket for a bit

@pbn4 pbn4 force-pushed the 1867/jurisdiction_program_entity branch from 0e58cb0 to b2f42fa Compare October 18, 2021 07:32
@pbn4
Copy link
Contributor Author

pbn4 commented Oct 18, 2021

Addresses #2000 too

Copy link
Collaborator

@seanmalbert seanmalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pbn4 ,
This looks good, but take a look at my feedback for the preference update PR, particularly in regard to how we're handling pages. Depending on how we handle that, this may need to get updated as well.

@seanmalbert
Copy link
Collaborator

@pbn4 ,
From our conversation in stand up yesterday around preferences and pages, @kathyccheng stated that programs like preferences will have their own separate pages and we can use the ordinal for that. And unlike preferences, which has a UI that relies on pages in the meantime, we can safely remove page from listing-program.

@seanmalbert seanmalbert merged commit 492ec4d into dev Oct 22, 2021
seanmalbert pushed a commit to CityOfDetroit/bloom that referenced this pull request Jun 23, 2022
* feat(backend): add Program entity

* Fix code style issues with Prettier

* feat(backend): Add programs to application entity

* Fix code style issues with Prettier

* feat(backend): Add Program seeds (bloom-housing#2034)

* feat(backend): Remove page from program entity

* Fix code style issues with Prettier

Co-authored-by: Lint Action <lint-action@samuelmeuli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants