fix: alternate contact email now validated #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👷 Deploy request for dev-partners-bloom pending review. 🔨 Explore the source changes: 30002f8 |
|
👷 Deploy request for dev-bloom pending review. 🔨 Explore the source changes: 30002f8 |
|
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 30002f8 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/61733475e7f893000784f9ed 😎 Browse the preview: https://deploy-preview-2035--dev-storybook-bloom.netlify.app |
emilyjablonski
approved these changes
Oct 22, 2021
seanmalbert
pushed a commit
to CityOfDetroit/bloom
that referenced
this pull request
Jun 23, 2022
* fix: alternate contact email now validated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
#2033
Addresses #issue
Description
On the public listing application form, the alternate contact email address was allowing non-emails to be entered. This change now enforces email validity
Type of change
How Can This Be Tested/Reviewed?
go through the public site's listing application process. When you get to the point of choosing an alternate contact, go through that process. Once you get to the alternate contact's email section, attempt to enter an invalid email (something "asf") and attempt to attempt to continue on with the form. This should be blocked by validation now.
If you change that to a real email (or an email that appears real) you should be able to progress with the form
Checklist:
yarn generate:clientif I made backend changes