Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updates lastName on application save #2107

Merged
merged 3 commits into from
Nov 2, 2021

Conversation

dominikx96
Copy link
Collaborator

@dominikx96 dominikx96 commented Oct 29, 2021

Pull Request Template

Issue Overview

This PR addresses #2094

  • This change addresses the issue in full
  • This change addresses only certain aspects of the issue
  • This change is a dependency for another issue
  • This change has a dependency from another issue

Description

Before fixing, the paper form (only, the public app saves fields correctly) saved the last name as a first name.

How Can This Be Tested/Reviewed?

  1. Submit a new paper application with the first, middle, and last name.
  2. In the summary, verify if the data is correct.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • I have exported any new pieces added to ui-components
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for dev-partners-bloom ready!

🔨 Explore the source changes: 7650370

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/617ba5ce4b371b0007e3eb31

😎 Browse the preview: https://deploy-preview-2107--dev-partners-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for dev-storybook-bloom ready!

🔨 Explore the source changes: 7650370

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/617ba5ce2cc21e0007464e93

😎 Browse the preview: https://deploy-preview-2107--dev-storybook-bloom.netlify.app

@netlify
Copy link

netlify bot commented Oct 29, 2021

✔️ Deploy Preview for dev-bloom ready!

🔨 Explore the source changes: 7650370

🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/617ba5ce9e1ca300086e64a5

😎 Browse the preview: https://deploy-preview-2107--dev-bloom.netlify.app

@@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file. The format
- Language typo in the paper applications table ([#1965](https://github.com/bloom-housing/bloom/pull/1965)) (Jared White)
- Improved UX for the Building Selection Criteria drawer ([#1994](https://github.com/bloom-housing/bloom/pull/1994)) (Jared White)
- alternate contact email is validated ([#2035](https://github.com/bloom-housing/bloom/pull/2035)) (Yazeed)
- Incorrect last name ([#2107](https://github.com/bloom-housing/bloom/pull/2107)) (Dominik Barcikowski)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder that we are no longer updating the changelog ourselves

@emilyjablonski
Copy link
Collaborator

emilyjablonski commented Oct 29, 2021

It does this weird visual thing where when you hit save and the form disables itself all the text fields go back to what they were before you edited them. But I'm sure that's a separate and existing issue, just is weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants