-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updates lastName on application save #2107
Conversation
✔️ Deploy Preview for dev-partners-bloom ready! 🔨 Explore the source changes: 7650370 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-partners-bloom/deploys/617ba5ce4b371b0007e3eb31 😎 Browse the preview: https://deploy-preview-2107--dev-partners-bloom.netlify.app |
✔️ Deploy Preview for dev-storybook-bloom ready! 🔨 Explore the source changes: 7650370 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-storybook-bloom/deploys/617ba5ce2cc21e0007464e93 😎 Browse the preview: https://deploy-preview-2107--dev-storybook-bloom.netlify.app |
✔️ Deploy Preview for dev-bloom ready! 🔨 Explore the source changes: 7650370 🔍 Inspect the deploy log: https://app.netlify.com/sites/dev-bloom/deploys/617ba5ce9e1ca300086e64a5 😎 Browse the preview: https://deploy-preview-2107--dev-bloom.netlify.app |
@@ -13,6 +13,7 @@ All notable changes to this project will be documented in this file. The format | |||
- Language typo in the paper applications table ([#1965](https://github.com/bloom-housing/bloom/pull/1965)) (Jared White) | |||
- Improved UX for the Building Selection Criteria drawer ([#1994](https://github.com/bloom-housing/bloom/pull/1994)) (Jared White) | |||
- alternate contact email is validated ([#2035](https://github.com/bloom-housing/bloom/pull/2035)) (Yazeed) | |||
- Incorrect last name ([#2107](https://github.com/bloom-housing/bloom/pull/2107)) (Dominik Barcikowski) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reminder that we are no longer updating the changelog ourselves
It does this weird visual thing where when you hit save and the form disables itself all the text fields go back to what they were before you edited them. But I'm sure that's a separate and existing issue, just is weird. |
Pull Request Template
Issue Overview
This PR addresses #2094
Description
Before fixing, the paper form (only, the public app saves fields correctly) saved the last name as a first name.
How Can This Be Tested/Reviewed?
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.