feat: upgrading typeorm #3340

YazeedLoonat · 2023-02-20T06:35:54Z

Pull Request Template

Issue Overview

This PR addresses #issue

This change addresses the issue in full

Description

This PR upgrades TypeORM to a much newer version

How Can This Be Tested/Reviewed?

To be honest every part of the system needs to be tested:
listings
creating, editing, viewing (public and partners)
applications
creating, editing, viewing (public and partners
users
creating, editing, viewing
duplicate listings
resolving, marking as duplicate, viewing

Checklist:

Reviewer Notes:

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

netlify · 2023-02-20T06:39:44Z

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	`3471d02`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/646412d17da88a00088d427a
😎 Deploy Preview	https://deploy-preview-3340--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backend/core/package.json

backend/core/src/migration/1676354438563-typeorm-upgrade.ts

backend/core/src/seeder/seed.ts

netlify · 2023-02-21T07:09:22Z

✅ Deploy Preview for bloom-core-orm ready!

Name	Link
🔨 Latest commit	`263c7c1`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-core-orm/deploys/6407ba022f1e5600087aeec2
😎 Deploy Preview	https://deploy-preview-3340--bloom-core-orm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backend/core/src/auth/helpers/user-helpers.ts

backend/core/src/auth/services/authz.service.ts

backend/core/src/auth/services/user.service.ts

backend/core/src/listings/db/listing-helpers.ts

netlify · 2023-02-21T18:10:09Z

✅ Deploy Preview for bloom-partners-orm ready!

Name	Link
🔨 Latest commit	`263c7c1`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-partners-orm/deploys/6407ba03e02c5c0008697a9d
😎 Deploy Preview	https://deploy-preview-3340--bloom-partners-orm.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

backend/core/package.json

emilyjablonski · 2023-02-22T19:04:13Z

@YazeedLoonat Any remaining concerns post-bash yesterday? Are you looking for more partners bashing on the preview link?

ludtkemorgan

I haven't found any functional issues, but still investigating how to solve that broken skipped test. There is a chance the AFS code has an issue, but more likely we just need to update the test somehow

backend/core/src/ami-charts/ami-charts.service.ts

backend/core/test/afs/afs.e2e-spec.ts

YazeedLoonat · 2023-05-08T23:24:11Z

@ludtkemorgan @seanmalbert @emilyjablonski @ColinBuyck this should be ready for re-review now!

ludtkemorgan

🦖 🌮

ColinBuyck · 2023-05-15T17:57:30Z

@YazeedLoonat do you mind resolving the merge conflicts when you get a chance? Hoping to test this with listings export!

YazeedLoonat · 2023-05-15T19:53:10Z

hey @ColinBuyck merge conflicts have been resolved, lemme know what you think

ColinBuyck

I'm unfortunately getting a 500 when working with an application set and attempting to resolve or save as a pending review

YazeedLoonat · 2023-05-17T16:02:21Z

Hey @ColinBuyck this should be good to go again

ColinBuyck

LGTM 🍌 I rate this 12/10!

* feat: upgrading typeorm * fix: updates for tests * fix: updating nestjs packages, clean up per morgan * fix: undoing nestjs bump * fix: missed changes * fix: minor typeorm version update * fix: user update per sean * fix: listings update per sean * fix: test updates * fix: hopefully resolves failing build on heroku * fix: attempt 2 on fixing heroku deploy * fix: updates * fix: update throttling in tests * fix: asset test fix * fix: updates for images and multiselect * fix: update for mfa * fix: type fix * fix: another type fix * fix: update for partner test * fix: issue with jurisdiction resolver service * fix: test fixes * fix: fix for mfa tests? * fix: attempt at mfa test fix * fix: remove listing service from afs cron job (bloom-housing#3428) * fix: update for tests * fix: fix for dup resolution --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Morgan Ludtke <42942267+ludtkemorgan@users.noreply.github.com>

* feat: upgrading typeorm (bloom-housing#3340) * feat: upgrading typeorm * fix: updates for tests * fix: updating nestjs packages, clean up per morgan * fix: undoing nestjs bump * fix: missed changes * fix: minor typeorm version update * fix: user update per sean * fix: listings update per sean * fix: test updates * fix: hopefully resolves failing build on heroku * fix: attempt 2 on fixing heroku deploy * fix: updates * fix: update throttling in tests * fix: asset test fix * fix: updates for images and multiselect * fix: update for mfa * fix: type fix * fix: another type fix * fix: update for partner test * fix: issue with jurisdiction resolver service * fix: test fixes * fix: fix for mfa tests? * fix: attempt at mfa test fix * fix: remove listing service from afs cron job (bloom-housing#3428) * fix: update for tests * fix: fix for dup resolution --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Morgan Ludtke <42942267+ludtkemorgan@users.noreply.github.com> * fix: upgrade all nest dependencies (bloom-housing#3461) * fix: add additional unit fields to base view (bloom-housing#3492) * Revert "fix: comment out income validation and change to text field (#620)" This reverts commit f56fdad. --------- Co-authored-by: Yazeed Loonat <YazeedLoonat@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com>

* feat: upgrading typeorm * fix: updates for tests * fix: updating nestjs packages, clean up per morgan * fix: undoing nestjs bump * fix: missed changes * fix: minor typeorm version update * fix: user update per sean * fix: listings update per sean * fix: test updates * fix: hopefully resolves failing build on heroku * fix: attempt 2 on fixing heroku deploy * fix: updates * fix: update throttling in tests * fix: asset test fix * fix: updates for images and multiselect * fix: update for mfa * fix: type fix * fix: another type fix * fix: update for partner test * fix: issue with jurisdiction resolver service * fix: test fixes * fix: fix for mfa tests? * fix: attempt at mfa test fix * fix: remove listing service from afs cron job (bloom-housing#3428) * fix: update for tests * fix: fix for dup resolution --------- Co-authored-by: Morgan Ludtke <ludtkemorgan@gmail.com> Co-authored-by: Sean Albert <smabert@gmail.com> Co-authored-by: Morgan Ludtke <42942267+ludtkemorgan@users.noreply.github.com>

feat: upgrading typeorm

1541837

YazeedLoonat added the 2 reviews needed Requires 2 more review before ready to merge label Feb 20, 2023

YazeedLoonat requested review from seanmalbert, ludtkemorgan, ColinBuyck and emilyjablonski February 20, 2023 06:35

YazeedLoonat self-assigned this Feb 20, 2023

ludtkemorgan reviewed Feb 20, 2023

View reviewed changes

backend/core/package.json Show resolved Hide resolved

backend/core/src/migration/1676354438563-typeorm-upgrade.ts Outdated Show resolved Hide resolved

backend/core/src/seeder/seed.ts Outdated Show resolved Hide resolved

ludtkemorgan temporarily deployed to bloom-backend-orm February 20, 2023 17:36 Inactive

ludtkemorgan temporarily deployed to bloom-backend-orm February 20, 2023 17:51 Inactive

ludtkemorgan temporarily deployed to bloom-backend-orm February 20, 2023 18:39 Inactive

ludtkemorgan temporarily deployed to bloom-backend-orm February 20, 2023 20:23 Inactive

fix: updates for tests

b80d7e8

fix: updating nestjs packages, clean up per morgan

517bf86

seanmalbert requested changes Feb 21, 2023

View reviewed changes

fix: undoing nestjs bump

da5fb5e

ludtkemorgan reviewed Feb 22, 2023

View reviewed changes

backend/core/package.json Show resolved Hide resolved

YazeedLoonat added 3 commits February 22, 2023 09:43

fix: missed changes

58a9461

fix: minor typeorm version update

c16cad7

fix: user update per sean

2811b4a

YazeedLoonat added 2 commits February 22, 2023 13:11

fix: listings update per sean

408b741

fix: test updates

ded1b63

YazeedLoonat temporarily deployed to bloom-backend-orm February 28, 2023 16:50 Inactive

ludtkemorgan temporarily deployed to bloom-backend-orm February 28, 2023 17:09 Inactive

ludtkemorgan temporarily deployed to bloom-backend-orm February 28, 2023 17:26 Inactive

YazeedLoonat temporarily deployed to bloom-backend-orm February 28, 2023 17:44 Inactive

ludtkemorgan requested changes May 5, 2023

View reviewed changes

backend/core/src/ami-charts/ami-charts.service.ts Outdated Show resolved Hide resolved

backend/core/test/afs/afs.e2e-spec.ts Outdated Show resolved Hide resolved

emilyjablonski added needs changes The author must make changes and then re-request review before merging and removed 2 reviews needed Requires 2 more review before ready to merge labels May 5, 2023

fix: remove listing service from afs cron job (#3428)

aa10b26

YazeedLoonat requested a review from ludtkemorgan May 8, 2023 17:36

YazeedLoonat added 2 commits May 8, 2023 10:38

Merge remote-tracking branch 'origin/main' into 3184/typeorm-upgrade

4dc8716

fix: update for tests

ee076a1

ludtkemorgan added 2 reviews needed Requires 2 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels May 12, 2023

ludtkemorgan approved these changes May 12, 2023

View reviewed changes

ludtkemorgan added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels May 12, 2023

Merge remote-tracking branch 'origin/main' into 3184/typeorm-upgrade

9f3a257

ColinBuyck requested changes May 15, 2023

View reviewed changes

ColinBuyck added the needs changes The author must make changes and then re-request review before merging label May 15, 2023

fix: fix for dup resolution

3471d02

YazeedLoonat requested a review from ColinBuyck May 17, 2023 16:02

YazeedLoonat removed the needs changes The author must make changes and then re-request review before merging label May 17, 2023

ColinBuyck approved these changes May 18, 2023

View reviewed changes

ColinBuyck added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels May 18, 2023

YazeedLoonat merged commit 287e3b0 into main May 22, 2023
8 checks passed

ludtkemorgan mentioned this pull request Jun 12, 2023

Release/2023 06 13 housingbayarea/bloom#622

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: upgrading typeorm #3340

feat: upgrading typeorm #3340

YazeedLoonat commented Feb 20, 2023

netlify bot commented Feb 20, 2023 •

edited

Loading

netlify bot commented Feb 21, 2023 •

edited

Loading

netlify bot commented Feb 21, 2023 •

edited

Loading

emilyjablonski commented Feb 22, 2023

ludtkemorgan left a comment

YazeedLoonat commented May 8, 2023

ludtkemorgan left a comment

ColinBuyck commented May 15, 2023

YazeedLoonat commented May 15, 2023

ColinBuyck left a comment •

edited

Loading

YazeedLoonat commented May 17, 2023

ColinBuyck left a comment

feat: upgrading typeorm #3340

feat: upgrading typeorm #3340

Conversation

YazeedLoonat commented Feb 20, 2023

Pull Request Template

Issue Overview

Description

How Can This Be Tested/Reviewed?

Checklist:

Reviewer Notes:

On Merge:

netlify bot commented Feb 20, 2023 • edited Loading

✅ Deploy Preview for bloom-exygy-dev ready!

netlify bot commented Feb 21, 2023 • edited Loading

✅ Deploy Preview for bloom-core-orm ready!

netlify bot commented Feb 21, 2023 • edited Loading

✅ Deploy Preview for bloom-partners-orm ready!

emilyjablonski commented Feb 22, 2023

ludtkemorgan left a comment

Choose a reason for hiding this comment

YazeedLoonat commented May 8, 2023

ludtkemorgan left a comment

Choose a reason for hiding this comment

ColinBuyck commented May 15, 2023

YazeedLoonat commented May 15, 2023

ColinBuyck left a comment • edited Loading

Choose a reason for hiding this comment

YazeedLoonat commented May 17, 2023

ColinBuyck left a comment

Choose a reason for hiding this comment

netlify bot commented Feb 20, 2023 •

edited

Loading

netlify bot commented Feb 21, 2023 •

edited

Loading

netlify bot commented Feb 21, 2023 •

edited

Loading

ColinBuyck left a comment •

edited

Loading