fix: redirect and alert language

[ColinBuyck]

Pull Request Template

Issue Overview

This PR addresses #3463

• This change addresses the issue in full
• This change addresses only certain aspects of the issue
• This change is a dependency for another issue
• This change has a dependency from another issue

Description

This fix redirects a user who lands at the beginning of an application for a listing that is closed. Couple notes:

1. Did my best on the language with the intention of it being clear while avoiding the repetition of "Applications Closed" seen on the right. Also curious how translations should be handled here? @sarahlazarich @eajensenwa

2. I recognize that this only covers the case of when a user hits the first step of an application for a closed listing directly as opposed to setting up the redirect for landing on any page. My thought is that, in the case of this quick fix, I shouldn't build in coverage for users skipping parts of our application since that seems like its own conversation/bug that isn't dependent on whether the listing is closed or not.

How Can This Be Tested/Reviewed?

This can be tested by pulling it down locally, setting a listing to closed, and then hitting this url:

http://localhost:3000/applications/start/choose-language?listingId= listingIdThatYouJustClosed

Checklist:

• My code follows the style guidelines of this project
• I have added QA notes to the issue with applicable URLs
• I have performed a self-review of my own code
• I have reviewed the changes in a desktop view
• I have reviewed the changes in a mobile view
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged and published in downstream modules
• I have assigned reviewers
• I have run yarn generate:client and/or created a migration if I made backend changes that require them
• My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
• Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

• Read and understand the issue, and ensure the author has added QA notes
• Review the code itself from a style point of view
• Pull the changes down locally and test that the acceptance criteria is met
• Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
• Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

[netlify]

✅ Deploy Preview for bloom-demo-public ready!

Name	Link
🔨 Latest commit	45669c5
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-demo-public/deploys/646e72ae0132530008e70890
😎 Deploy Preview	https://deploy-preview-3467--bloom-demo-public.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[netlify]

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	45669c5
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/646e72ad3f7775000855f934
😎 Deploy Preview	https://deploy-preview-3467--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[sarahlazarich]

I think the language in the error message is good, and agree w your thought on the related bug. We can translate in google for now (see below) and I'll let Izzie know to send jurisdictions an FYI.

Translations:

• Filipino: Ang listahang ito ay hindi na tumatanggap ng mga aplikasyon
• Chinese: 此房源不再接受申请
• Vietnamese: Danh sách này không còn chấp nhận các ứng dụng
• Spanish: Esta lista ya no acepta solicitudes

[eajensenwa]

language looks good to me!

[ludtkemorgan]

This looks good. I think it might be useful to add it to a few more pages. Specifically the other ones in the "start" folder (autofill and what-to-expect). Also it might be a good idea to do the last page of the flow so the user doesn't get the error until after they submit. Thoughts?

[emilyjablonski]

@ludtkemorgan I wonder if we need to think more about a big picture solution before we start adding it to individual pages, I think ideally long term we just add this once, wondering if this can be our quick fix?

[ColinBuyck]

Sorry to bug ya again @eajensenwa but just want to verify that the site alert styling/design looks good to you 🧲

[eajensenwa]

yep, looks great! 🎨

[ludtkemorgan]

@ludtkemorgan I wonder if we need to think more about a big picture solution before we start adding it to individual pages, I think ideally long term we just add this once, wondering if this can be our quick fix?

I briefly spoke to colin in the huddle. I think it makes sense to not add it to all of the pages so I'm ok with just having it on the choose-language page. However, I do think we would get a lot of bang for our buck if we put it on the last page as well for this quick fix. That way it will catch everyone, even if they come from a different page since we don't know exactly how this is happening at the moment. The long term fix will require a bit more considerations

[emilyjablonski]

@ludtkemorgan makes sense, sounds great!

[ColinBuyck]

Updated @emilyjablonski @ludtkemorgan 📟

[ludtkemorgan]

⏰

[YazeedLoonat]

LGTM