-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: filter flagged duplicate sets #4097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emilyjablonski
commented
May 22, 2024
emilyjablonski
commented
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few nits and some questions
...ners/src/components/applications/PaperApplicationDetails/sections/DetailsApplicationData.tsx
Outdated
Show resolved
Hide resolved
sites/partners/src/pages/listings/[id]/applications/pending/index.tsx
Outdated
Show resolved
Hide resolved
sites/partners/src/pages/listings/[id]/applications/resolved/index.tsx
Outdated
Show resolved
Hide resolved
YazeedLoonat
approved these changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
May 22, 2024
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
May 22, 2024
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
May 22, 2024
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Issue Overview
This PR addresses #4100
Description
Allows for the ability to search on application flagged sets by the first/last names of any applicant in a set.
Pending Set
![Screenshot 2024-05-21 at 1 11 28 PM](https://private-user-images.githubusercontent.com/65367387/332615704-4ca4e554-be6e-43a4-b5a8-fe367d66383b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NTExMjUsIm5iZiI6MTcxOTY1MDgyNSwicGF0aCI6Ii82NTM2NzM4Ny8zMzI2MTU3MDQtNGNhNGU1NTQtYmU2ZS00M2E0LWI1YTgtZmUzNjdkNjYzODNiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA4NDcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmYjNiODAyZmExNGYzODNmZTQzMTc0MDU3NTAyY2Y0MGEwYjJlYWVlM2Q3MzczMWY3NTQ2MzllM2NjMDdmNjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.1qIyZBLCeZj--ANJdPOXujHGDd5w73FZMPu-W21okzw)
![Screenshot 2024-05-21 at 1 11 33 PM](https://private-user-images.githubusercontent.com/65367387/332615701-7406646e-e4fc-4933-b540-aedc970799eb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NTExMjUsIm5iZiI6MTcxOTY1MDgyNSwicGF0aCI6Ii82NTM2NzM4Ny8zMzI2MTU3MDEtNzQwNjY0NmUtZTRmYy00OTMzLWI1NDAtYWVkYzk3MDc5OWViLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA4NDcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzYWZjNGNkMjI5M2M0NzEwOTNhNjE1MGFhZWI3NjhkNzM3NjczYWYxYTI3NWEwODg1MGJhNDRjN2U4MDFhODYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.VbcBf5Ox1wGtLE-c7uLUVGz_zTfbKk4hDSuLYiSpv6Y)
The information in the first column was duplicated in the next two columns. Now the duplicate information is removed and we are showing the names of all applicants in the first column since there really is no "primary applicant" in a set and it was really confusing to search for an applicant name and have a line appear that didn't show that applicant's name, but because the applicant was in the set.
Before:
After:
Resolved Set
![Screenshot 2024-05-21 at 1 12 00 PM](https://private-user-images.githubusercontent.com/65367387/332615698-6a3a3f94-65a2-4348-ada8-89990d484d1c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NTExMjUsIm5iZiI6MTcxOTY1MDgyNSwicGF0aCI6Ii82NTM2NzM4Ny8zMzI2MTU2OTgtNmEzYTNmOTQtNjVhMi00MzQ4LWFkYTgtODk5OTBkNDg0ZDFjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA4NDcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTgzOGQwMmNlNzRhMjU2ZjhlOWI5N2I2MGViMzIzNWRiMDY3MDEzOTkxMzdhNjk2ODk3MzY0YmVhNjhmMTZkODcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.--3V_QMRK1x4zzI8GzXZ6SGEtXsTAtIUUMUNPoQwX0w)
![Screenshot 2024-05-21 at 1 12 14 PM](https://private-user-images.githubusercontent.com/65367387/332615696-306d72e8-ff95-4572-a524-34a0e0c15dc0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTk2NTExMjUsIm5iZiI6MTcxOTY1MDgyNSwicGF0aCI6Ii82NTM2NzM4Ny8zMzI2MTU2OTYtMzA2ZDcyZTgtZmY5NS00NTcyLWE1MjQtMzRhMGUwYzE1ZGMwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA2MjklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNjI5VDA4NDcwNVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTVlYTUxNjU3MmVhZDJiNzY4YTMzOTQ0NDI5YTRhZmJlYTY0MTcwM2U1MmViYThjYzE2YzgzNjEzZWM3MThiYTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.pdwWQb9HP1S2vHBE9x1nsbg2tffv0A-XAyDc4g9zCic)
Similar changes, duplicate information is removed and all applicant names are being shown
Before:
After:
Additionally, because that first column now needs to take up lots of space, I had to make adjustments to the sizes of the columns. I saw that the column sizes were wonky on all partners tables, so I lightly adjusted the spacings based on what I learned in the flagged set table.
How Can This Be Tested/Reviewed?
Go to a listing with pending and resolved sets of application duplicates and try to search for names.
You can also look at the listing and application tables if you want to see some new column sizes. It's fairly subtle there.
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.