Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter flagged duplicate sets #4097

Merged
merged 6 commits into from
May 22, 2024
Merged

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented May 21, 2024

Pull Request Template

Issue Overview

This PR addresses #4100

  • This change addresses the issue in full

Description

Allows for the ability to search on application flagged sets by the first/last names of any applicant in a set.

Pending Set
The information in the first column was duplicated in the next two columns. Now the duplicate information is removed and we are showing the names of all applicants in the first column since there really is no "primary applicant" in a set and it was really confusing to search for an applicant name and have a line appear that didn't show that applicant's name, but because the applicant was in the set.
Before:
Screenshot 2024-05-21 at 1 11 28 PM
After:
Screenshot 2024-05-21 at 1 11 33 PM

Resolved Set
Similar changes, duplicate information is removed and all applicant names are being shown
Before:
Screenshot 2024-05-21 at 1 12 00 PM
After:
Screenshot 2024-05-21 at 1 12 14 PM

Additionally, because that first column now needs to take up lots of space, I had to make adjustments to the sizes of the columns. I saw that the column sizes were wonky on all partners tables, so I lightly adjusted the spacings based on what I learned in the flagged set table.

How Can This Be Tested/Reviewed?

Go to a listing with pending and resolved sets of application duplicates and try to search for names.

You can also look at the listing and application tables if you want to see some new column sizes. It's fairly subtle there.

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit ddce686
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/664d66bb6fb3e60008c31155
😎 Deploy Preview https://deploy-preview-4097--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@emilyjablonski emilyjablonski changed the title feat: filter flagged sets feat: filter flagged duplicate sets May 21, 2024
@emilyjablonski emilyjablonski marked this pull request as ready for review May 22, 2024 01:16
@emilyjablonski emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label May 22, 2024
Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few nits and some questions

Copy link
Collaborator

@YazeedLoonat YazeedLoonat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels May 22, 2024
@emilyjablonski emilyjablonski merged commit d5cbc2a into main May 22, 2024
20 checks passed
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request May 22, 2024
emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request May 22, 2024
emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request May 22, 2024
emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants