fix: improve seed data and validity #4099

emilyjablonski · 2024-05-21T23:28:34Z

Pull Request Template

Description

I ran into a lot of issues testing duplicate problems locally because of some invalid and missing seed data - this PR fixes a handful of problems related to seed data and a few bugs with how that data was showing up in the applications table. I added a comment to each fix. It also types two application fields with an enum that were previously just a set of strings the frontend was sending to the backend.

How Can This Be Tested/Reviewed?

Run yarn setup:dev and check out the applications table on a listing to see more applications with more data and more variety.

Submit an application and fill out alternate contact and household member data to ensure it comes through as expected on the partners side to ensure the new typing places nicely.

Checklist:

Reviewer Notes:

Steps to review a PR:

Read and understand the issue, and ensure the author has added QA notes
Review the code itself from a style point of view
Pull the changes down locally and test that the acceptance criteria is met
Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

emilyjablonski · 2024-05-21T23:29:11Z

api/prisma/seed-dev.ts

-          householdMember: householdMembers,
-          multiselectQuestions,
-        }),
+    for (let j = 0; j <= APPLICATIONS_PER_LISTINGS - 1; j++) {


Previously, all applications had the same household size and same household members, and one more application than the actual APPLICATIONS_PER_LISTING

real nit pick: could we change this to for (let j = 0; j < APPLICATIONS_PER_LISTINGS; j++) {
just a lil less code

emilyjablonski · 2024-05-21T23:32:56Z

api/prisma/seed-helpers/household-member-factory.ts

+            create: addressFactory(),
+          }
+        : undefined,
+    orderId: index,


Without this new index, we were previously unable to view individual household members on an application in partners

api/prisma/constants.ts

emilyjablonski · 2024-05-22T00:02:57Z

api/prisma/seed-helpers/alternate-contact-factory.ts

+        phoneNumber: undefined,
+        emailAddress: undefined,
+        agency: undefined,
+        address: { create: addressFactory() },


This is technically inaccurate but we're sending a strange empty-but-with-id address on alternate contact through the frontend on actual application submission and that felt like a bigger problem

emilyjablonski · 2024-05-22T00:03:45Z

api/prisma/seed-helpers/household-member-factory.ts

+    birthDay: randomBirthDay(),
+    birthYear: randomBirthYear(),
+    sameAddress: YesNoEnum.yes,
+    relationship: relationshipKeys[randomInt(relationshipKeys.length)],


Now including relationship

emilyjablonski · 2024-05-22T00:04:26Z

api/prisma/seed-helpers/jurisdiction-factory.ts

@@ -6,7 +6,7 @@ export const jurisdictionFactory = (
  listingApprovalPermissions?: UserRoleEnum[],
 ): Prisma.JurisdictionsCreateInput => ({
  name: jurisdictionName,
-  notificationsSignUpUrl: null,
+  notificationsSignUpUrl: 'https://www.exygy.com',


Allows the notifications block to show up in dev

netlify · 2024-05-22T00:04:53Z

✅ Deploy Preview for bloom-exygy-dev ready!

Name	Link
🔨 Latest commit	`fffa375`
🔍 Latest deploy log	https://app.netlify.com/sites/bloom-exygy-dev/deploys/665fa09af920580007cea782
😎 Deploy Preview	https://deploy-preview-4099--bloom-exygy-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

emilyjablonski · 2024-05-22T00:05:14Z

sites/partners/src/components/applications/ApplicationsColDefs.ts

@@ -492,7 +492,7 @@ export function getColDefs(maxHouseholdSize: number, countyCode: string) {

  const householdCols = []

-  for (let i = 0; i < maxHouseholdSize; i++) {
+  for (let i = 0; i < maxHouseholdSize - 1; i++) {


Previously on the applications table in partners, we were always showing an additional set of household member columns that never had data

emilyjablonski · 2024-05-22T00:05:30Z

sites/partners/src/components/applications/ApplicationsColDefs.ts

@@ -562,7 +562,7 @@ export function getColDefs(maxHouseholdSize: number, countyCode: string) {
        width: 125,
        minWidth: 100,
        valueFormatter: ({ value }) => {
-          if (!value) return ""
+          if (value.length < householdIndex) return ""


Previously, we were showing n/a just in these columns for otherwise empty household members

emilyjablonski · 2024-05-22T00:05:47Z

...ers/src/components/applications/PaperApplicationDetails/sections/DetailsAlternateContact.tsx

-          dataTestId="alternateContact"
-        />
-      </Grid.Row>
+      {application.alternateContact?.type !== AlternateContactRelationship.noContact && (


If there is no alternate contact, don't show the address section for it

emilyjablonski · 2024-05-22T00:06:28Z

...ers/src/components/applications/PaperApplicationDetails/sections/DetailsHouseholdMembers.tsx

-    birth: t("application.household.member.dateOfBirth"),
-    sameResidence: t("application.add.sameResidence"),
-    workInRegion: t("application.details.workInRegion"),
+    name: "t.name",


This was throwing console errors - it's a little odd but the function these are passed into just takes the string which it passes into t()

emilyjablonski · 2024-05-22T00:56:36Z

api/prisma/seed-helpers/alternate-contact-factory.ts

Alternate contact didn't exist

emilyjablonski · 2024-05-22T02:59:18Z

api/prisma/seed-helpers/application-factory.ts

Just added missing data

mcgarrye · 2024-05-28T15:08:35Z

api/src/enums/applications/alternate-contact-relationship-enum.ts

@@ -0,0 +1,7 @@
+export enum AlternateContactRelationship {


Can we check with product if we should be making this and the HouseholdMemberRelationship enums readable in the CSV export?

@emilyjablonski can you also make a ticket to change the db to be enums instead of strings as well

I think that work needs to be captured separately as the roll out for it will require migrations and db work

And that CSV issue looks existing, but I'll look for a ticket!

YazeedLoonat

Looks good!
some questions and nits

api/prisma/constants.ts

YazeedLoonat · 2024-05-29T18:21:03Z

api/prisma/seed-dev.ts

-          householdMember: householdMembers,
-          multiselectQuestions,
-        }),
+    for (let j = 0; j <= APPLICATIONS_PER_LISTINGS - 1; j++) {


real nit pick: could we change this to for (let j = 0; j < APPLICATIONS_PER_LISTINGS; j++) {
just a lil less code

YazeedLoonat · 2024-05-29T18:22:08Z

api/prisma/seed-helpers/alternate-contact-factory.ts

+
+export const alternateContactFactory =
+  (): Prisma.AlternateContactCreateWithoutApplicationsInput => {
+    const relationshipKeys = Object.values(AlternateContactRelationship);


this paired with line 12 is so smart!

I stole it from Morgan haha

api/prisma/seed-helpers/alternate-contact-factory.ts

YazeedLoonat · 2024-05-29T18:30:02Z

api/src/enums/applications/alternate-contact-relationship-enum.ts

@@ -0,0 +1,7 @@
+export enum AlternateContactRelationship {


@emilyjablonski can you also make a ticket to change the db to be enums instead of strings as well

I think that work needs to be captured separately as the roll out for it will require migrations and db work

sites/partners/src/components/applications/ApplicationsColDefs.ts

sites/partners/src/lib/applications/formatApplicationData.ts

emilyjablonski · 2024-06-04T23:18:56Z

@YazeedLoonat So sorry, I re-requested a review, but realized I never actually pushed the commit lol

YazeedLoonat

LGTM

fix: improve seed data and validity

aa33935

emilyjablonski commented May 21, 2024

View reviewed changes

emilyjablonski added 2 commits May 21, 2024 17:54

fix: improve seed data and validity

878fa3d

fix: improve seed data and validity

b0db792

emilyjablonski commented May 22, 2024

View reviewed changes

api/prisma/constants.ts Outdated Show resolved Hide resolved

emilyjablonski commented May 22, 2024

View reviewed changes

fix: app edit

5615fb3

emilyjablonski commented May 22, 2024

View reviewed changes

api/prisma/seed-helpers/alternate-contact-factory.ts

Copy link

Collaborator Author

emilyjablonski May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate contact didn't exist

emilyjablonski added 3 commits May 21, 2024 19:03

test: maybe fix test

f85707e

test: fix import

5947983

test: fix import

40ae736

emilyjablonski commented May 22, 2024

View reviewed changes

api/prisma/seed-helpers/application-factory.ts Outdated

Copy link

Collaborator Author

emilyjablonski May 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just added missing data

emilyjablonski added the 1 review needed Requires 1 more review before ready to merge label May 22, 2024

emilyjablonski marked this pull request as ready for review May 22, 2024 03:01

mcgarrye approved these changes May 28, 2024

View reviewed changes

YazeedLoonat requested changes May 29, 2024

View reviewed changes

YazeedLoonat added needs changes The author must make changes and then re-request review before merging and removed 1 review needed Requires 1 more review before ready to merge labels May 29, 2024

fix: pr review

fffa375

emilyjablonski added 1 review needed Requires 1 more review before ready to merge and removed needs changes The author must make changes and then re-request review before merging labels Jun 3, 2024

emilyjablonski requested a review from YazeedLoonat June 3, 2024 21:31

YazeedLoonat approved these changes Jun 5, 2024

View reviewed changes

YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 5, 2024

emilyjablonski merged commit adab010 into main Jun 5, 2024
20 checks passed

emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request Jun 6, 2024

fix: improve seed data and validity (bloom-housing#4099)

3e40156

emilyjablonski mentioned this pull request Jun 6, 2024

fix: release - account saving issue and seed data metrotranscom/doorway#665

Closed

emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Jun 6, 2024

fix: improve seed data and validity (bloom-housing#4099)

d9d9abf

emilyjablonski mentioned this pull request Jun 6, 2024

fix: release - account saving issue and seed data housingbayarea/bloom#707

Merged

emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request Jun 11, 2024

fix: improve seed data and validity (bloom-housing#4099)

d173b03

emilyjablonski mentioned this pull request Jun 11, 2024

fix: release - seed data and account profile saving issues metrotranscom/doorway#670

Merged

emilyjablonski added a commit to metrotranscom/doorway that referenced this pull request Jun 13, 2024

fix: improve seed data and validity (bloom-housing#4099)

e49a665

emilyjablonski added a commit to housingbayarea/bloom that referenced this pull request Jun 27, 2024

fix: improve seed data and validity (bloom-housing#4099)

c61e1c9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: improve seed data and validity #4099

fix: improve seed data and validity #4099

emilyjablonski commented May 21, 2024 •

edited

Loading

emilyjablonski May 21, 2024 •

edited

Loading

YazeedLoonat May 29, 2024

emilyjablonski May 21, 2024 •

edited

Loading

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024

netlify bot commented May 22, 2024 •

edited

Loading

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024 •

edited

Loading

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024

emilyjablonski May 22, 2024

mcgarrye May 28, 2024

YazeedLoonat May 29, 2024

emilyjablonski Jun 3, 2024

emilyjablonski Jun 3, 2024

emilyjablonski Jun 3, 2024

YazeedLoonat left a comment

YazeedLoonat May 29, 2024

YazeedLoonat May 29, 2024

emilyjablonski May 30, 2024

YazeedLoonat May 29, 2024

emilyjablonski commented Jun 4, 2024

YazeedLoonat left a comment

fix: improve seed data and validity #4099

fix: improve seed data and validity #4099

Conversation

emilyjablonski commented May 21, 2024 • edited Loading

Pull Request Template

Description

How Can This Be Tested/Reviewed?

Checklist:

Reviewer Notes:

On Merge:

emilyjablonski May 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilyjablonski May 21, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

netlify bot commented May 22, 2024 • edited Loading

✅ Deploy Preview for bloom-exygy-dev ready!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilyjablonski May 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

YazeedLoonat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

emilyjablonski commented Jun 4, 2024

YazeedLoonat left a comment

Choose a reason for hiding this comment

emilyjablonski commented May 21, 2024 •

edited

Loading

emilyjablonski May 21, 2024 •

edited

Loading

emilyjablonski May 21, 2024 •

edited

Loading

netlify bot commented May 22, 2024 •

edited

Loading

emilyjablonski May 22, 2024 •

edited

Loading