Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: script runner data transfer part 1 #4104

Merged
merged 4 commits into from
May 30, 2024

Conversation

YazeedLoonat
Copy link
Collaborator

Issue Overview

This PR addresses #issue

  • This change addresses the issue in full

Description

This creates an endpoint in the script runner controller, and a function in the script runner service to start doing data transfer

The new endpoint takes in the database connection string in order to connect to the db

How Can This Be Tested/Reviewed?

Spin up the api locally -> head to lhttp://localhost:3101/api/ or http://localhost:3100/api/ -> get the production database connection string -> log in as an admin or juris admin user via the openapi doc -> hit the script runner's data transfer endpoint passing in the database connection string

you should get success: true on the openapi response, and your api terminal should have a console log with the jurisdiction id for San Mateo from the production db

Checklist:

  • My code follows the style guidelines of this project
  • I have added QA notes to the issue with applicable URLs
  • I have performed a self-review of my own code
  • I have reviewed the changes in a desktop view
  • I have reviewed the changes in a mobile view
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have assigned reviewers
  • I have run yarn generate:client and/or created a migration if I made backend changes that require them
  • My commit message(s) is/are polished, and any breaking changes are indicated in the message and are well-described
  • Commits made across packages purposefully have the same commit message/version change, else are separated into different commits

Reviewer Notes:

Steps to review a PR:

  • Read and understand the issue, and ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Also review the acceptance criteria on the Netlify deploy preview (noting that these do not yet include any backend changes made in the PR)
  • Either explicitly ask a clarifying question, request changes, or approve the PR if there are small remaining changes but the PR is otherwise good to go

On Merge:

If you have one commit and message, squash. If you need each message to be applied, rebase and merge.

@YazeedLoonat YazeedLoonat added the 2 reviews needed Requires 2 more review before ready to merge label May 22, 2024
Copy link

netlify bot commented May 22, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 0bf352c
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/665608568d4037000845ca89
😎 Deploy Preview https://deploy-preview-4104--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

api/.env.template Outdated Show resolved Hide resolved
Copy link
Collaborator

@mcgarrye mcgarrye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcgarrye mcgarrye added 1 review needed Requires 1 more review before ready to merge and removed 2 reviews needed Requires 2 more review before ready to merge labels May 28, 2024
@YazeedLoonat YazeedLoonat added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels May 30, 2024
@YazeedLoonat YazeedLoonat merged commit 69c64b9 into main May 30, 2024
20 checks passed
YazeedLoonat added a commit to housingbayarea/bloom that referenced this pull request May 31, 2024
* feat: creates data transfer endpoint in script runner

* fix: change query to read jurisdiction data

* fix: updates to add unit tests

* fix: update per eric
YazeedLoonat added a commit to metrotranscom/doorway that referenced this pull request Jun 3, 2024
* feat: creates data transfer endpoint in script runner

* fix: change query to read jurisdiction data

* fix: updates to add unit tests

* fix: update per eric
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants