-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: script runner data transfer part 1 #4104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YazeedLoonat
added
the
2 reviews needed
Requires 2 more review before ready to merge
label
May 22, 2024
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
16 tasks
mcgarrye
reviewed
May 23, 2024
mcgarrye
approved these changes
May 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mcgarrye
added
1 review needed
Requires 1 more review before ready to merge
and removed
2 reviews needed
Requires 2 more review before ready to merge
labels
May 28, 2024
YazeedLoonat
added
ready to merge
Should be applied when a PR has been reviewed and approved
and removed
1 review needed
Requires 1 more review before ready to merge
labels
May 30, 2024
YazeedLoonat
added a commit
to housingbayarea/bloom
that referenced
this pull request
May 31, 2024
* feat: creates data transfer endpoint in script runner * fix: change query to read jurisdiction data * fix: updates to add unit tests * fix: update per eric
YazeedLoonat
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 3, 2024
* feat: creates data transfer endpoint in script runner * fix: change query to read jurisdiction data * fix: updates to add unit tests * fix: update per eric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Overview
This PR addresses #issue
Description
This creates an endpoint in the script runner controller, and a function in the script runner service to start doing data transfer
The new endpoint takes in the database connection string in order to connect to the db
How Can This Be Tested/Reviewed?
Spin up the api locally -> head to lhttp://localhost:3101/api/ or http://localhost:3100/api/ -> get the production database connection string -> log in as an admin or juris admin user via the openapi doc -> hit the script runner's data transfer endpoint passing in the database connection string
you should get success: true on the openapi response, and your api terminal should have a console log with the jurisdiction id for San Mateo from the production db
Checklist:
yarn generate:client
and/or created a migration if I made backend changes that require themReviewer Notes:
Steps to review a PR:
On Merge:
If you have one commit and message, squash. If you need each message to be applied, rebase and merge.