fix: saving user account info #4121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
emilyjablonski
commented
Jun 6, 2024
emilyjablonski
commented
Jun 6, 2024
emilyjablonski
added
the
1 review needed
emilyjablonski
added
2 reviews needed
mcgarrye
added
1 review needed
ludtkemorgan
approved these changes
Jun 6, 2024
ludtkemorgan
added
ready to merge
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 6, 2024
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 6, 2024
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 11, 2024
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 13, 2024
emilyjablonski
added a commit
to metrotranscom/doorway
that referenced
this pull request
Jun 13, 2024
fix: change type of income voucher fix: test issue fix: test issue fix: build issue fix: cypress tests fix: env vars fix: rebase issues fix: rebase issues
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
emilyjablonski
added a commit
to housingbayarea/bloom
that referenced
this pull request
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses metrotranscom#631
Description
This PR fixes two bugs on the user account screen:
It seemed like the problem with the first bug was that we are setting the form field defaults if the user profile is present, and when you go back in the browser, the profile is present and wasn't refetching, so I am fetching the user on page load, and after every user update I am re-setting the user object. Because I'm fetching on page load and that data is required in the UI, I pulled in our loading overlay over the card.
We were also having validation issues because we have separate forms on the page but we were not actually setting up the forms as separate as react-hook-forms expects - validation for all fields was triggering on submitting just one of them - so I separated these out into four separate forms as well.
How Can This Be Tested/Reviewed?
Follow the steps above and ensure they work!
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: