Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include check for address type #4136

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses #4135

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the logic to show the submit application section to account for the mailing and dropoff addresses to be undefined but the address type is same as leasing agent.

Note: That this will be pulled into Doorway Asap

How Can This Be Tested/Reviewed?

Create a listing with "Are postmarks considered?" marked as Yes, a paper app attached, indicate a received by date & time, and with both the mailing address and the drop-off address marked as same as the leasingAgentAddress... the submit application section should show on the public side with the corresponding postmark information.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@ColinBuyck ColinBuyck added the 1 review needed Requires 1 more review before ready to merge label Jun 12, 2024
Copy link

netlify bot commented Jun 12, 2024

Deploy Preview for bloom-exygy-dev ready!

Name Link
🔨 Latest commit 12e7ce7
🔍 Latest deploy log https://app.netlify.com/sites/bloom-exygy-dev/deploys/6669f0681283430007fca713
😎 Deploy Preview https://deploy-preview-4136--bloom-exygy-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@emilyjablonski emilyjablonski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛝

@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed Requires 1 more review before ready to merge labels Jun 12, 2024
@ColinBuyck ColinBuyck merged commit 726e992 into main Jun 12, 2024
20 checks passed
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Jun 12, 2024
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Jun 12, 2024
ColinBuyck added a commit to metrotranscom/doorway that referenced this pull request Jun 12, 2024
ColinBuyck added a commit to housingbayarea/bloom that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants