This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Simplify onResponse to remove unneeded promise layers. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| req.log.error(err, 'Request error.'); | ||
| return next(new restify.InternalError(err.message)); | ||
| req.blpSession.request(util.format('//%s/%s', req.query.ns, req.query.service), | ||
| req.query.type, |
|
Note: Let's not merge this until #83 is landed first. |
|
lgtm |
|
LGTM too. Will hold off merging until #83 landed. |
|
@yupinghu - feel free to squash |
The wrapper's request function is already asynchronous, and now that session handling is done earlier in middleware, we can make requests a bit simpler. I also took the opportunity to simplify how the response text is formed. It should be possible to do the same sort of thing for subscriptions but that will be a separate change.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The wrapper's request function is already asynchronous, and
now that session handling is done earlier in middleware, we
can make requests a bit simpler. I also took the opportunity
to simplify how the response text is formed.
It should be possible to do the same sort of thing for
subscriptions but that will be a separate change.