Skip to content
This repository has been archived by the owner on Jan 8, 2019. It is now read-only.

rebase on release 3.3 #1256

Conversation

leochen4891
Copy link
Contributor

function "get_static_head_node_local_ip_list" is only in master but not release-3.3

@leochen4891 leochen4891 requested a review from vt0r August 9, 2018 04:49
@vt0r vt0r added the wontfix label Aug 9, 2018
@vt0r
Copy link
Member

vt0r commented Aug 9, 2018

Hey, Lei. This actually has already been backported (and adjusted to work on the older release).

Here is the version in master: https://github.com/bloomberg/chef-bach/blob/master/cookbooks/bcpc/libraries/utils.rb#L242-L253

And the backported functions in release-3.3: https://github.com/bloomberg/chef-bach/blob/release-3.3/cookbooks/bcpc/libraries/utils.rb#L227-L238

I think we can close this PR, unless you had issues with 3.3.22, in which case I'd be happy to help fix them.

@vt0r vt0r added WIP and removed wontfix labels Aug 9, 2018
@leochen4891
Copy link
Contributor Author

leochen4891 commented Aug 10, 2018

It is this line that caused nilClass.
2a713e6#diff-e473d582c04b36ee0446aa84637ef780R388
Will fix it by moving calculation out of carbon.conf.erb file.

#1258

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants