Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdb2api: Configuring DNS suffix at compile time. #1438

Merged
merged 1 commit into from Apr 5, 2019

Conversation

riverszhang89
Copy link
Contributor

/silent this is no applicable to cdb2jdbc.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review suggestions:

@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.

@riverszhang89
Copy link
Contributor Author

/silent ...

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/255 tests failed ⚠.

The first 10 failing tests are:
pg_free_recovery

Detail | Log | Resubmit

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sysbench Transactions Per Second:

@@ sysbench/select_random_points @@
-7.03%
@@ sysbench/bulk_insert @@
+0.32%
@@ sysbench/select_random_ranges @@
-4.25%
@@ sysbench/oltp_insert @@
-0.65%
@@ sysbench/oltp_read_only @@
-0.81%
@@ sysbench/oltp_point_select @@
-0.99%
@@ sysbench/oltp_update_non_index @@
-0.23%
@@ sysbench/oltp_delete @@
+0.11%
@@ sysbench/oltp_update_index @@
-1.36%

@riverszhang89 riverszhang89 merged commit 54a9c2f into bloomberg:master Apr 5, 2019
@riverszhang89 riverszhang89 deleted the cdb2apidns branch April 5, 2019 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants