New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue of low load on first node #1498
Fix issue of low load on first node #1498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!
It appears that you have not provided a description. To help us review your pull request, please consider providing an overview of the following:
-
What is the type of the change (bugfix, feature, documentation and etc.)
-
What are the current behavior and expected behavior, if this is a bugfix
-
What are the steps to reproduce the bug, if this is a bugfix
-
What are the current behavior and new behavior, if this is a feature change
-
Why is the new behavior better than the current behavior, if this is a feature change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review suggestions:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Error. Use clang-format or view diff ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 1/261 tests failed ⚠.
The first 10 failing tests are:
odh_blobs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request!
It appears that you have not provided a description. To help us review your pull request, please consider providing an overview of the following:
-
What is the type of the change (bugfix, feature, documentation and etc.)
-
What are the current behavior and expected behavior, if this is a bugfix
-
What are the steps to reproduce the bug, if this is a bugfix
-
What are the current behavior and new behavior, if this is a feature change
-
Why is the new behavior better than the current behavior, if this is a feature change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review suggestions:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coding style check: Success ✓.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: Success ✓.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sysbench Transactions Per Second (commit: 4996499):
@@ sysbench/select_random_points @@
-10.09%
@@ sysbench/bulk_insert @@
-4.04%
@@ sysbench/select_random_ranges @@
-0.44%
@@ sysbench/oltp_insert @@
-0.92%
@@ sysbench/oltp_read_only @@
+3.19%
@@ sysbench/oltp_point_select @@
-12.10%
@@ sysbench/oltp_update_non_index @@
+0.78%
@@ sysbench/oltp_delete @@
-13.27%
@@ sysbench/oltp_update_index @@
-0.02%
@@ sysbench/oltp_read_write @@
+1.70%
@@ sysbench/oltp_write_only @@
+14.54%
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sysbench Transactions Per Second (commit: b1344ce):
@@ sysbench/select_random_points @@
-9.93%
@@ sysbench/bulk_insert @@
-4.69%
@@ sysbench/select_random_ranges @@
+3.56%
@@ sysbench/oltp_insert @@
-1.81%
@@ sysbench/oltp_read_only @@
+3.89%
@@ sysbench/oltp_point_select @@
-12.04%
@@ sysbench/oltp_update_non_index @@
-1.41%
@@ sysbench/oltp_delete @@
-12.79%
@@ sysbench/oltp_update_index @@
-0.72%
@@ sysbench/oltp_read_write @@
+1.50%
@@ sysbench/oltp_write_only @@
+13.46%
No description provided.