Tunable to serialize schema change object in 7.0 format #4449
Conversation
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ berkdb/db/trigger_subscription.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ berkdb/env/env_method.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/reqlog.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please replace any pthread_xxx() function in your diff with corresponding Pthread_xxx() wrapper.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Error ⚠.
Cbuild submission: Success ✓.
Regression testing: 495/528 tests failed ⚠.
The first 10 failing tests are:
rebuild_table_options
cldeadlock
sc_constraints
sc_constraints_logicalsc_generated
selectv_deadlock
sc_inserts_deletes_partial_index_off_generated
sc_inserts_deletes_logicalsc_generated
sc_inserts_deletes
truncatesc_ufid_on_generated
truncatesc
dorinhogea
force-pushed
the
save_sc_in_7format
branch
from
92b71f8
to
d7c1821
Compare
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ berkdb/db/trigger_subscription.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ berkdb/env/env_method.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/reqlog.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please replace any pthread_xxx() function in your diff with corresponding Pthread_xxx() wrapper.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 3/529 tests failed ⚠.
The first 10 failing tests are:
truncatesc_offline_generated
sc_timepart_logicalsc_generated
truncatesc
dorinhogea
force-pushed
the
save_sc_in_7format
branch
from
d7c1821
to
8f7a734
Compare
There was a problem hiding this comment.
Lint check:
@@ cdb2api/cdb2api.c @@
+ Please port the change to cdb2jdbc if necessary.
+ If you add any internal configuration state to this file, please update the reset_the_configuration() function as well to include it.
@@ db/db_tunables.h @@
+ Please update the tunable documentation (docs/pages/config/config_files.md) accordingly.
@@ berkdb/db/trigger_subscription.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ berkdb/env/env_method.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ db/reqlog.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please make sure that a mutex is unlocked before returning.
@@ plugins/reversesql/reversesql.c @@
+ Please replace any pthread_xxx() function in your diff with corresponding Pthread_xxx() wrapper.
There was a problem hiding this comment.
Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 4/529 tests failed ⚠.
The first 10 failing tests are:
truncatesc_offline_generated
sc_downgrade
sc_lotsoftables_logicalsc_generated
sc_lotsoftables
|
cdb2test May 28 13:38:50 2024 in-comdb2db save_sc_in_7format.R20240528.2 |
… race with server upgrade. To run the testcase you need to setup a mixed cluster by hand and run the script like ./runit dbname oneofthenodes Signed-off-by: Dorin Hogea <dhogea@bloomberg.net>
dorinhogea
force-pushed
the
save_sc_in_7format
branch
from
8f7a734
to
a50724b
Compare
|
@mponomar thank you |
This will allow us to deploy the backward incompatible format in 8.0 to clusters with 7.0.
Details:
When 'sc_7format' is enabled, the wire and disk serialized schema change object is identical with 7.0 code. The 8.0 replicant sends a 7.0 format and a 8.0 master reads a 7.0 format, but doing the rest of the work with updated structure.
Meanwhile, 7.0 replicants and masters will be able to process the objects with the old code.
Idea is to enable this only on for 7.0 clusters; existing 8.0 clusters need to run with this disabled during the patch deployment.