Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context consistency updates #24

Merged
merged 2 commits into from
Dec 9, 2020
Merged

Context consistency updates #24

merged 2 commits into from
Dec 9, 2020

Conversation

mikesep
Copy link
Member

@mikesep mikesep commented Dec 8, 2020

  • Pass context into internal/tempbuild.Build
  • Use exec.Command in tests

@mikesep
Pass context into tempbuild.Build
3eb3c73 
Prevents us from forgetting that there's a context involved in running
'go build'.

Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
@mikesep
Use exec.Command in tests
be858e0 
exec.CommandContext() with context.Background() doesn't wasn't adding
any value in these cases.

Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 408999649

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.568%
Totals Coverage Status
Change from base Build 408987817: 0.0%
Covered Lines: 685
Relevant Lines: 810
💛 - Coveralls

@mikesep mikesep changed the title Context updates Context consistency updates Dec 8, 2020
@mikesep mikesep merged commit 9fc10dd into bloomberg:main Dec 9, 2020
@mikesep mikesep deleted the context-usage branch December 9, 2020 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatCulhane PatCulhane PatCulhane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mikesep @coveralls @PatCulhane