Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use testgroup for our tests and add an example #26

Merged
merged 1 commit into from
Dec 16, 2020

Conversation

mikesep
Copy link
Member

@mikesep mikesep commented Dec 9, 2020

No description provided.

Signed-off-by: Mike Seplowitz <mseplowitz@bloomberg.net>
@coveralls
Copy link

Pull Request Test Coverage Report for Build 411025181

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.568%

Totals Coverage Status
Change from base Build 410977533: 0.0%
Covered Lines: 685
Relevant Lines: 810

💛 - Coveralls

Copy link

@PatCulhane PatCulhane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at some point i need to do a review of all this outside of the context of a PR so i can have more of the mindset of someone reading the repo to figure out how to use it rather than the mindset of a maintainer who, at least in theory, already knows.

@mikesep mikesep merged commit 906cc5e into bloomberg:main Dec 16, 2020
@mikesep mikesep deleted the testgroup branch December 16, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants