Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter/sort controls not selectable in latest version #446

Closed
zwelz3 opened this issue Sep 16, 2023 · 9 comments
Closed

Filter/sort controls not selectable in latest version #446

zwelz3 opened this issue Sep 16, 2023 · 9 comments

Comments

@zwelz3
Copy link

zwelz3 commented Sep 16, 2023

Describe the bug
Filter/sort controls not selectable in latest ipydatagrid release.

To Reproduce
Steps to reproduce the behavior:

  1. Install ipydatagrid==1.2.0
  2. Run default DataGrid.ipynb example
  3. Try to click on the filter/sort icon for a column
  4. Observe no UI is triggered for filter/sort column

Expected behavior
Prior to 1.2.0 clicking the column icon would open a UI (see below)

image

Environment (please complete the following information):

  • Operating System and Version: Windows 10 Enterprise Version 10.0.19045
  • Browser [e.g. Firefox, Safari] (if applicable):- Chrome Version 116.0.5845.180 (Official Build) (64-bit)
@jgunstone
Copy link
Contributor

just double checked this and have the same problem -
the version on binder isn't working in the way described

@aloneguid
Copy link

same here!

@kaizenloop
Copy link

Also having this issue in the same way described

@aloneguid
Copy link

I had to downgrade to previous version, works fine.

@martinRenou
Copy link
Member

I think we need to revert #441 for a patch release as it seems to have broken the button entirely.

@ywahl
Copy link

ywahl commented Jan 23, 2024

When will this PR be included in a next official release?

@martinRenou
Copy link
Member

When #469 gets merged :)

@cmc-emmet
Copy link

@martinRenou - given that we're now at version 1.3.1 has this Issue been resolved?

@martinRenou
Copy link
Member

martinRenou commented Apr 24, 2024

Indeed, this has been resolved in 1.2.1.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants