Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle renderer update #14

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Handle renderer update #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
40 changes: 28 additions & 12 deletions src/datagrid.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,12 +187,7 @@ class DataGridView extends DOMWidgetView {
});

this.grid.model = this.model.data_model;

this.grid.cellRenderers.set('body', {}, this.default_renderer.renderer);

for (const key in this.renderers) {
this.grid.cellRenderers.set('body', {'name': key}, this.renderers[key].renderer);
}
this._update_grid_renderers();

this.model.on('change:base_row_size', () => {
this.grid.baseRowSize = this.model.get('base_row_size');
Expand All @@ -214,21 +209,32 @@ class DataGridView extends DOMWidgetView {
this.grid.headerVisibility = this.model.get('header_visibility');
});

this.model.on_some_change(['default_renderer', 'renderers'], () => {
this._update_renderers().then(this._update_grid_renderers.bind(this));
}, this);

this.pWidget.addWidget(this.grid);
});
}

_update_renderers() {
// Unlisten to previous renderers
if (this.default_renderer) {
this.stopListening(this.default_renderer, 'renderer_changed');
}
for (const key in this.renderers) {
this.stopListening(this.renderers[key], 'renderer_changed');
}

// And create views for new renderers
let promises = [];

const default_renderer = this.model.get('default_renderer');
if (default_renderer) {
promises.push(this.create_child_view(default_renderer).then((default_renderer_view: any) => {
this.default_renderer = default_renderer_view;
promises.push(this.create_child_view(default_renderer).then((default_renderer_view: any) => {
this.default_renderer = default_renderer_view;

this.listenTo(this.default_renderer, 'renderer_changed', this._repaint.bind(this));
}));
}
this.listenTo(this.default_renderer, 'renderer_changed', this._repaint.bind(this));
}));

let renderer_promises: Dict<Promise<any>> = {};
_.each(this.model.get('renderers'), (model: CellRendererModel, key: string) => {
Expand All @@ -245,6 +251,16 @@ class DataGridView extends DOMWidgetView {
return Promise.all(promises);
}

_update_grid_renderers() {
this.grid.cellRenderers.clear();

this.grid.cellRenderers.set('body', {}, this.default_renderer.renderer);

for (const key in this.renderers) {
this.grid.cellRenderers.set('body', {'name': key}, this.renderers[key].renderer);
}
}

_repaint() {
this.grid.repaint();
}
Expand Down