fixup! fixup! Add a progress bar indicator for record processing

Stop tracking num processed allocations in RecordReader Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
bloomberg · May 19, 2022 · 669bde5 · 669bde5
1 parent 78109e7
commit 669bde5
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 12 deletions.
diff --git a/src/memray/_memray/record_reader.cpp b/src/memray/_memray/record_reader.cpp
@@ -440,7 +440,6 @@ RecordReader::nextRecord()
                     if (d_input->is_open()) LOG(ERROR) << "Failed to process allocation record";
                     return RecordResult::ERROR;
                 }
-                d_processed_allocations += 1;
                 return RecordResult::ALLOCATION_RECORD;
             } break;
             case RecordType::ALLOCATION_WITH_NATIVE: {
@@ -453,7 +452,6 @@ RecordReader::nextRecord()
                     }
                     return RecordResult::ERROR;
                 }
-                d_processed_allocations += 1;
                 return RecordResult::ALLOCATION_RECORD;
             } break;
             case RecordType::MEMORY_RECORD: {
@@ -637,12 +635,6 @@ RecordReader::getLatestMemoryRecord() const noexcept
     return d_latest_memory_record;
 }
 
-size_t
-RecordReader::getProcessedAllocations() const noexcept
-{
-    return d_processed_allocations;
-}
-
 PyObject*
 RecordReader::dumpAllRecords()
 {

diff --git a/src/memray/_memray/record_reader.h b/src/memray/_memray/record_reader.h
@@ -1,7 +1,6 @@
 #pragma once
 
 #include <assert.h>
-#include <atomic>
 #include <fstream>
 #include <functional>
 #include <limits>
@@ -51,7 +50,6 @@ class RecordReader
     std::string getThreadName(thread_id_t tid);
     Allocation getLatestAllocation() const noexcept;
     MemoryRecord getLatestMemoryRecord() const noexcept;
-    size_t getProcessedAllocations() const noexcept;
 
   private:
     // Aliases
@@ -85,7 +83,6 @@ class RecordReader
     std::unordered_map<thread_id_t, std::string> d_thread_names;
     Allocation d_latest_allocation;
     MemoryRecord d_latest_memory_record;
-    std::atomic<size_t> d_processed_allocations{0};
 
     // Methods
     [[nodiscard]] bool parseFramePush(FramePush* record);

diff --git a/src/memray/_memray/record_reader.pxd b/src/memray/_memray/record_reader.pxd
@@ -30,4 +30,3 @@ cdef extern from "record_reader.h" namespace "memray::api":
         string getThreadName(long int tid) except+
         Allocation getLatestAllocation()
         MemoryRecord getLatestMemoryRecord()
-        size_t getProcessedAllocations()