Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make clean breaks virtualenvs stored inside the repo clone #353

Closed
godlygeek opened this issue Apr 23, 2023 · 1 comment · Fixed by #363
Closed

make clean breaks virtualenvs stored inside the repo clone #353

godlygeek opened this issue Apr 23, 2023 · 1 comment · Fixed by #363
Assignees
@jayybhatt
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@godlygeek
Copy link
Contributor

If you create a virtualenv inside a clone of the repo, running make clean will break it by removing all of the *.so files inside of it. We should improve our make clean to only remove files that we know we've created.
@godlygeek godlygeek added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Apr 23, 2023
@jayybhatt
Copy link
Contributor

jayybhatt commented Apr 24, 2023 •
edited
Loading

I'll take this one

@jayybhatt jayybhatt mentioned this issue Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jayybhatt jayybhatt

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only delete the *.so files that we create jayybhatt/memray
2 participants
@godlygeek @jayybhatt