Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only delete the *.so files that we create #363

Merged
merged 1 commit into from
Apr 24, 2023

Conversation

jayybhatt
Copy link
Contributor

*Issue number of the reported bug or feature request: #353 *

Describe your changes
Delete only the following:

  • _test_utils
  • _memray
  • _inject
  • build/ dir

Testing performed
To make sure that the virtualenv is working after running make clean, I did the following,

  • Installed some packages in the virtualenv
  • Start the interpreter and import a few modules

Additional context
Closes #353

Signed-off-by: Jay Bhatt <jayybhatt007@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@godlygeek godlygeek merged commit 6f4559c into bloomberg:main Apr 24, 2023
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make clean breaks virtualenvs stored inside the repo clone
2 participants