Exclude libbacktrace from our built wheel #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `find_namespace_packages` instead of `find_packages` results in `src/vendor/` being picked up as a namespace package called `vendor` and included in the wheel that we build. This is only needed at build time, and shouldn't be installed. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
This is redundant, as we're already providing `include_package_data=True`, which includes every data file listed in the manifest, including `py.typed`. Signed-off-by: Matt Wozniski <godlygeek@gmail.com>
pablogsal
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove vendored libbacktrace from our built wheel. Using
find_namespace_packagesinstead offind_packagesresults insrc/vendor/being picked up as a namespace package calledvendorand included in the wheel that we build. This is only needed at build time, and shouldn't be installed.Also, remove
package_datafrom oursetuptools.setup()call. This is redundant, as we're already providinginclude_package_data=True, which includes every data file listed in the manifest, includingpy.typed.