Recognize and handle truncated capture files #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
godlygeek
force-pushed
the
mitigate_truncated_files
branch
from
8b26a85
to
ec29f83
Compare
pablogsal
reviewed
Jun 10, 2022
pablogsal
reviewed
Jun 10, 2022
pablogsal
reviewed
Jun 10, 2022
pablogsal
previously approved these changes
Jun 10, 2022
godlygeek
force-pushed
the
mitigate_truncated_files
branch
from
ec29f83
to
2653a01
Compare
Make the `RecordWriter` finish a capture file by writing a non-zero trailer byte that the `RecordReader` will ignore. When the `FileSource` reads a (non-compressed) capture file, have it ignore any trailing zero bytes without returning them to the caller. If the caller attempts to read into them, treat it as though EOF has been reached instead. When a trailer byte is encountered by the reader, treat it as EOF, rather than continuing to request bytes from the reader. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
pablogsal
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
RecordWriterfinish a capture file by writing a non-zerotrailer byte that the
RecordReaderwill ignore. When theFileSourcereads a (non-compressed) capture file, have it ignore any trailing zero
bytes without returning them to the caller. If the caller attempts to
read into them, treat it as though EOF has been reached instead.
When a trailer byte is encountered by the reader, treat it as EOF,
rather than continuing to request bytes from the reader.
Signed-off-by: Matt Wozniski mwozniski@bloomberg.net