Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plot with heap size to the flamegraph/table memory plot #142

Merged
merged 1 commit into from Jun 15, 2022

Conversation

pablogsal
Copy link
Member

To allow users to compare resident size and allocated size over time,
add a new plot line to the graphs that we show in the different reporter
that shows also allocated memory size.

This commit also changes the memory records to include the heap size as
well as the resident size.

Signed-off-by: Pablo Galindo pablogsal@gmail.com

news/142.feature Outdated Show resolved Hide resolved
src/memray/_memray/records.h Show resolved Hide resolved
tests/integration/test_tracking.py Outdated Show resolved Hide resolved
tests/integration/test_tracking.py Outdated Show resolved Hide resolved
@pablogsal pablogsal force-pushed the heap branch 3 times, most recently from 8fcc1f5 to 690b639 Compare June 15, 2022 17:40
To allow users to compare resident size and allocated size over time,
add a new plot line to the graphs that we show in the different reporter
that shows also allocated memory size.

This commit also changes the memory records to include the heap size as
well as the resident size.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. MemorySnapshot is definitely a better name for the Python type that will one day be exposed as part of a public API, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants