Fix several live mode bugs #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before the first sample, we have seen no threads, and our next/prev thread handling would accidentally divide by zero trying to see if we need to wrap around to the other end of our list. Additionally, we would display the thread as "Thread 1 of 0", which isn't great. Work around this by starting off with a dummy list of thread IDs, and replace it with a real one the first time we see an allocation. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
pablogsal
reviewed
Jun 15, 2022
Expose `flush` from `Sink` (making it a no-op for everything but the socket sink), and have the `RecordWriter` call it whenever a `MemoryRecord` is written. Since we know that these are only written periodically, this means we won't be calling `flush()` too often, but since they're written multiple times a second, that means that our TUI won't be stuck displaying stale data for long just because the new data is stuck in a buffer in the tracked process. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
Rely on the fact that the repr of a string can be evaluated to produce an equivalent string in order to prevent an injection bug when passing the command or script to run from the `memray run --live` parent process to the child process where the command will be run. Signed-off-by: Matt Wozniski <mwozniski@bloomberg.net>
pablogsal
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143
Closes #145
Closes #146