Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a memray entry point #20

Merged
merged 1 commit into from Apr 21, 2022
Merged

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 20, 2022

Closes: #12

Currently we only have memray3.X as an entry point but having also
memray as an entry point will make it easier for people with only one
Python version installed and it would make the usage examples from -h
line up with how we actually expect it to be used.

This commit also updates the docs and the README file to simplify the
examples with the new entry point.

@pablogsal pablogsal force-pushed the entry_point branch 2 times, most recently from 7940a06 to 7f584fe Compare April 20, 2022 13:02
Currently we only have `memray3.X` as an entry point but having also
`memray` as an entry point will make it easier for people with only one
Python version installed and it would make the usage examples from -h
line up with how we actually expect it to be used.

This commit also updates the docs and the README file to simplify the
examples with the new entry point.
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I removed some no longer needed parentheticals, and spotted a place where we were unnecessarily using implicit string literal concatenation in setup.lpy

@godlygeek godlygeek merged commit c175350 into bloomberg:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we have a memray entry point?
2 participants