Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new transform subcomand #200

Merged
merged 1 commit into from
Sep 9, 2022
Merged

Add a new transform subcomand #200

merged 1 commit into from
Sep 9, 2022

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 2, 2022

Add a new transform subcomand that allows to translate memray result files
into output files compatible with other tools. As a first output format
we add also a gprof2dot format that allows to produce graph-like
reports when combined with graphviz.

Signed-off-by: Pablo Galindo pablogsal@gmail.com

Issue number of the reported bug or feature request: #

Describe your changes
A clear and concise description of the changes you have made.

Testing performed
Describe the testing you have performed to ensure that the bug has been addressed, or that the new feature works as planned.

Additional context
Add any other context about your contribution here.

@godlygeek
Copy link
Contributor

"convert" or "transform" seem like better names for this than "dump"

@pradyunsg
Copy link
Member

export is another option.

@pablogsal pablogsal changed the title Add a new dump subcomand Add a new transform subcomand Sep 3, 2022
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, plus I made some fixup commits for some things.

tests/unit/test_transform_reporter.py Show resolved Hide resolved
src/memray/commands/transform.py Outdated Show resolved Hide resolved
Add a new `transform` subcomand that allows to translate memray result
files into output files compatible with other tools. As a first output
format we add also a `gprof2dot` format that allows to produce
graph-like reports when combined with `graphviz`.

Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
Copy link
Contributor

@godlygeek godlygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal pablogsal merged commit 4df1eff into bloomberg:main Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants